Add SSHFP record lookups#1033
Open
skreuzer wants to merge 1 commit into
Open
Conversation
* Add SSHFP record lookups.
kgaughan
reviewed
May 18, 2026
kgaughan
left a comment
kgaughan
left a comment
There was a problem hiding this comment.
You should probably update integration-tests/goss/goss-shared.yaml too, otherwise there's no way to test for this in the integration tests.
| - "dns.google." | ||
|
|
||
| # Validate and SRV record | ||
| # Validate a SRV record |
There was a problem hiding this comment.
Picky, I know,
Suggested change
| # Validate a SRV record | |
| # Validate an SRV record |
| - "0 5 443 a.dnstest.io." | ||
| - "10 10 443 b.dnstest.io." | ||
|
|
||
| # Validate a SSHFP record |
There was a problem hiding this comment.
Suggested change
| # Validate a SSHFP record | |
| # Validate an SSHFP record |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
This commit implements SSHFP (SSH Fingerprint) DNS record type support, allowing you to validate that the ssh host key fingerprints stored in dns match what you expect
📚 Documentation preview 📚: https://goss--1033.org.readthedocs.build/en/1033/