Update golang-lint CI to final v1 release: v1.64.8#1038
Open
kgaughan wants to merge 1 commit into
Open
Conversation
3 tasks
Collaborator
|
lgtm. I don't know (yet), however, how come Travis or the github workflows have not run. |
Author
|
@petemounce, @aelsabbahy or another maintainer needs to allow them to be triggered. It's a guard GH puts in place to prevent the service to be DOS'd by malicious pull requests. |
Collaborator
That's what I figure too. However, I do not see in the UI any workflows awaiting approval as the docs suggest I should. |
Collaborator
|
It's possible travis needs to be re-authenticated |
Author
|
@ripienaar How would we go about getting that fixed up? |
Additionally, fix up a few minor issues caught by it.
kgaughan
force-pushed
the
golangci-lint-upgrade
branch
from
46c2b4b to
684b813
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
This update is needed to cover some spurious failing typecheck golangci-lint tests that start being flagged if the dependencies are upgraded.
Additionally, fix up a few minor issues caught by it.
Just to note, but when I ran
make test-linux-allon the master branch, the integration tests aren't working as expected because there have been some changes in the packages in RockyLinux, issues with DNS records exposed bydnstest.io, and a few other such issues. I get the same set of issues running on either the master branch or on the PR. It looks like some work is needed to fix the integration tests separately from all this.