Change unique indexes for form documents to allow for multiple versions - #3021
Merged
Conversation
stephencdaly
force-pushed
the
change-unique-indexes-for-form-documents
branch
2 times, most recently
from
August 13, 2026 13:29
ff263af to
9ae8d85
Compare
stephencdaly
marked this pull request as ready for review
August 13, 2026 13:39
stephencdaly
changed the title
stephencdaly
marked this pull request as draft
August 13, 2026 13:50
stephencdaly
force-pushed
the
change-unique-indexes-for-form-documents
branch
2 times, most recently
from
August 13, 2026 15:03
b4ada4b to
b43a8a7
Compare
stephencdaly
marked this pull request as ready for review
August 13, 2026 15:07
lfdebrux
previously approved these changes
Aug 14, 2026
Allow: - One form_document with the same language and version per form - One form_document with the same language and a null version per form to account for draft forms The indexes are not added concurrently, as the benefits of adding them in a transaction outweigh the potental downsides of locking the table for a short time.
Delete the tests for the data migration rake task to backfill versons as the new indexes do not allow for multiple form_documents with the same language and a null version per form. This rake task has been run in all environments - but we'll keep it around slightly longer so devs can run it if they need to backfill their local databases.
stephencdaly
force-pushed
the
change-unique-indexes-for-form-documents
branch
from
August 14, 2026 09:15
b43a8a7 to
36f6228
Compare
Contributor
Author
|
@theseanything I've updated to not add the indexes concurrently and instead use a transaction, as discussed |
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3021.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
theseanything
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/dGv0TrD1
Update the unique indexes for form documents so that:
A migration has already been run on all environments to set the version for live and archived form documents to 1
Things to consider when reviewing