Add environment name to OTel metrics - #2188
Merged
Merged
Conversation
Set deployment.environment.name as a resource attribute in the ADOT collector metrics pipeline so metrics in CloudWatch can be filtered and grouped by environment (dev, staging, production).
There was a problem hiding this comment.
Pull request overview
Adds the deployment environment name to ADOT/OTel metrics emitted from ECS services by injecting deployment.environment.name as a resource attribute in the collector configuration. This centralizes environment tagging in infrastructure so CloudWatch metrics can be filtered/grouped by environment without requiring each application to set the attribute.
Changes:
- Pass
env_nameinto the ADOT collector config Terraform template. - Add a
resource/envprocessor that upsertsdeployment.environment.nameinto resource attributes. - Wire the new processor into the metrics pipeline (
resourcedetection/ecs -> resource/env -> batch/metrics).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| infra/modules/ecs-service/adot.tf | Passes env_name into the ADOT collector config templatefile inputs. |
| infra/modules/ecs-service/adot-collector-config.yaml.tpl | Adds a resource processor to set deployment.environment.name and includes it in the metrics pipeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DavidBiddle
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set deployment.environment.name as a resource attribute in the ADOT collector metrics pipeline so metrics in CloudWatch can be filtered and grouped by environment (dev, staging, production).
This allows not to have to set the environment name in the application itself for every single metric.
Tested in dev.