Skip to content

Remove copy of answers feature flag - #2224

Merged
stephencdaly merged 1 commit into
mainfrom
remove-copy-of-answers-feature-flag
Jul 31, 2026
Merged

Remove copy of answers feature flag#2224
stephencdaly merged 1 commit into
mainfrom
remove-copy-of-answers-feature-flag

Conversation

@stephencdaly

@stephencdaly stephencdaly commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/EAwRqQMh

This feature flag no longer exists in the app code, so the terraform to set the environment variable can be removed.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

Copilot AI review requested due to automatic review settings July 31, 2026 10:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes Terraform configuration for the deprecated “copy of answers / send filler answers” feature flag from the forms-admin deployment, since the application no longer consumes this setting.

Changes:

  • Removed the send_filler_answers module input variable from infra/modules/forms-admin.
  • Removed the SETTINGS__FEATURES__SEND_FILLER_ANSWERS ECS environment variable wiring.
  • Removed send_filler_answers from forms-admin settings inputs and all environment tfvars (dev/staging/production).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
infra/modules/forms-admin/variables.tf Removes the send_filler_answers variable definition from the module interface.
infra/modules/forms-admin/main.tf Removes the ECS task env var entry for SETTINGS__FEATURES__SEND_FILLER_ANSWERS.
infra/deployments/forms/tfvars/dev.tfvars Removes the send_filler_answers setting from dev config.
infra/deployments/forms/tfvars/staging.tfvars Removes the send_filler_answers setting from staging config.
infra/deployments/forms/tfvars/production.tfvars Removes the send_filler_answers setting from production config.
infra/deployments/forms/inputs.tf Updates the forms_admin_settings object type to drop send_filler_answers.
infra/deployments/forms/forms-admin/main.tf Removes passing send_filler_answers into the forms_admin module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stephencdaly
stephencdaly added this pull request to the merge queue Jul 31, 2026
Merged via the queue into main with commit 900c174 Jul 31, 2026
21 checks passed
@stephencdaly
stephencdaly deleted the remove-copy-of-answers-feature-flag branch July 31, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants