Repository navigation
cmdline: Support multiple queries on the command line - #4718
Merged
kainino0x merged 1 commit intoOct 15, 2026
Merged
Conversation
Load and run test cases for all positional query arguments instead of asserting queries.length === 1.
Contributor
Author
|
Do I need to add tests anywhere? |
kainino0x
approved these changes
Oct 15, 2026
kainino0x
left a comment
kainino0x
left a comment
Collaborator
There was a problem hiding this comment.
no, I don't think we have or really need tests for the command line interface.
kainino0x
enabled auto-merge (squash)
October 15, 2026 07:18
copybara-service Bot
pushed a commit
to google/dawn
that referenced
this pull request
Oct 28, 2026
-q can be given several times, --query-file reads queries or test cases from a file or stdin, one test case per line, and all of them run in one cmdline.js session, so a supervisor can hand the runner a batch of test cases. Single cases are looked up by name, since a case name does not always parse back to its own parameters. StringListOption gains SplitOnComma(false) for values that contain commas. process.abort() is polyfilled so the same crash fixtures run under node and the runner. This needs the cmdline.js from gpuweb/cts#4718, in the pending CTS roll. R=dsinclair@chromium.org Bug: 555264246, 571890980 Change-Id: I0b664d9c616b5a6dd29fce6cb598c4465f206ef0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/352475 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: dan sinclair <dsinclair@chromium.org> Auto-Submit: Steven Perron <stevenperron@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load and run test cases for all positional query arguments in
cmdline.tsinstead of assertingqueries.length === 1.