Skip to content

fix: use correct apostrophe#1301

Merged
KnorpelSenf merged 3 commits into
mainfrom
fix/ua-apostrophe-use
Jul 16, 2026
Merged

fix: use correct apostrophe#1301
KnorpelSenf merged 3 commits into
mainfrom
fix/ua-apostrophe-use

Conversation

@LWJerri

@LWJerri LWJerri commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@LWJerri
LWJerri requested a review from KnorpelSenf June 18, 2026 01:03
@LWJerri
LWJerri marked this pull request as ready for review June 18, 2026 01:03
@github-actions

github-actions Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

🚀 Deployed on https://6a593d9633614b2c7d66021a--grammy.netlify.app

@github-actions
github-actions Bot temporarily deployed to pull request June 18, 2026 01:04 Inactive
KnorpelSenf
KnorpelSenf reviewed Jun 18, 2026
View reviewed changes

@KnorpelSenf KnorpelSenf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this done automatically during the build step because we have enabled smart quotes?

If no, would it be better to fix vitepress and add support there? If yes, we can merge this in the meantime and then revert later on.

@LWJerri

LWJerri commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author

Isn't this done automatically during the build step because we have enabled smart quotes?

If no, would it be better to fix vitepress and add support there? If yes, we can merge this in the meantime and then revert later on.

Tbh, I don't know what "smart quotes" are, but it seems like this feature isn't enabled, and I'm not sure if it can even be enabled, since we haven't received any notifications over all this time indicating that we have incorrect quotation marks in some places.

@KnorpelSenf

KnorpelSenf commented Jun 19, 2026

Copy link
Copy Markdown
Member

I was referring to the typographer config option which is set here:

website/site/docs/.vitepress/config.ts

Line 41 in 68a3f37

typographer: true,

Look for smartquotes here: https://markdown-it.github.io/markdown-it/?hl=de-DE

KnorpelSenf
KnorpelSenf approved these changes Jul 16, 2026
View reviewed changes

@KnorpelSenf KnorpelSenf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood

@KnorpelSenf KnorpelSenf added typo Spelling error or other small mistake not translatable Translator intervention is not required. style Language style 🇺🇦 UK Modifies or is related to the Ukrainian translations. labels Jul 16, 2026
@github-actions
github-actions Bot temporarily deployed to pull request July 16, 2026 20:23 Inactive
@KnorpelSenf
KnorpelSenf added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit c4b8866 Jul 16, 2026
9 of 11 checks passed
@KnorpelSenf
KnorpelSenf deleted the fix/ua-apostrophe-use branch July 16, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KnorpelSenf KnorpelSenf KnorpelSenf approved these changes

Assignees

No one assigned

Labels

not translatable Translator intervention is not required. style Language style typo Spelling error or other small mistake 🇺🇦 UK Modifies or is related to the Ukrainian translations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LWJerri @KnorpelSenf