Repository navigation
Add further f-block examples - #22
Merged
Merged
Conversation
awvwgk
reviewed
Oct 4, 2026
| - name: Build library (CMake) | ||
| run: cmake --build ${{ env.C_BUILD_DIR }} | ||
|
|
||
| - name: Run unit tests (CTest) |
Member
There was a problem hiding this comment.
Why do we drop the cmake testing?
Member
Author
There was a problem hiding this comment.
There aren't actually any active tests anymore since mctc-lib runs its tests only as a top-level library (mctc-lib#135). This also happens in all other projects using mctc-lib. We can add them back by adding the mctc-lib tester directly.
awvwgk
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a few more f-block examples with lower symmetry and different composition.
Additionally, I updated the CI. Since mctc-lib#135, there are no Cmake tests left for mstore, and I removed the ctest. Alternatively, we have to include the mctc-lib tester as a top-level dependency. The same is true in dftd4, simple-dftd3, ... if we still want to run mctc-lib tests.