Add multi-NIC support: multiple network adapters per VM - #144
Open
groundwater wants to merge 3 commits into
Open
Add multi-NIC support: multiple network adapters per VM#144groundwater wants to merge 3 commits into
groundwater wants to merge 3 commits into
Conversation
Introduce NetworkInterfaceConfig to allow VMs to have multiple network interfaces (e.g. NAT + bridged). Each interface has its own label, mode, and MAC address. VMStoredConfig auto-migrates legacy single-NIC configs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Includes RouterConfig, CustomNetworkStore, and all associated UI views (CustomNetworkListView, RouterDetailView, etc.) that are referenced by NetworkSettingsView and SwiftUIDemoApp in DEBUG builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Implement the packet processing backend for custom network mode, replacing the NAT fallback with a full user-space network stack: ARP responder, DHCP server, NAT engine, DNS forwarder, firewall engine, and port forwarder. VMConfigurationBuilder now creates a socketpair with VZFileHandleNetworkDeviceAttachment for custom NICs. Remove all #if DEBUG gates around custom network UI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
groundwater
force-pushed
the
feature/multi-nic-support
branch
from
March 1, 2026 06:48
f403ad8 to
e1d8def
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NetworkInterfaceConfigdata model pairing a label,NetworkConfig, and MAC address per NICVMStoredConfiggains anetworkInterfacesarray with automatic migration from legacy singlenetworkConfig+macAddressVMConfigurationBuilderloops over interfaces to create oneVZVirtioNetworkDeviceConfigurationper NICVMControllergenerates/regenerates MAC addresses per-interface in init, clone, and session creationNetworkInterfaceListViewUI with reorder (up/down), add, remove, and sheet editor embeddingNetworkSettingsViewCreateVMViewandEditVMViewwired to use the new multi-NIC UITest plan
networkInterfaces[0]ifconfig)🤖 Generated with Claude Code