Skip to content

feat(git-shipping): define PR body as Summary, Evidence, Impact - #168

Merged
h3y6e merged 1 commit into
mainfrom
feat/git-shipping-pr-body-content
Oct 15, 2026
Merged

h3y6e merged 1 commit into
mainfrom
feat/git-shipping-pr-body-content

Conversation

@h3y6e

@h3y6e h3y6e commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

PR bodies written with git-shipping now have three sections and show changes above the level of the diff, not as a file-by-file list.

Evidence

-## Summary / ## Background / ## Changes / ## Impact
+## Summary   outcome, then why now
+## Evidence  before/after as trees or pseudocode, never copied diff lines; omitted for small diffs
+## Impact    (optional) door, blast radius, reviewer notes

Subagents wrote bodies for h3y6e/anna#7 with each version of the skill. Verbatim excerpts:

Before, ## Changes:

  • Add a llamacpp adapter that calls the OpenAI-compatible /v1/embeddings endpoint and orders results by response index.
  • Replace --ollama-url and --embedding-model with --embedder-provider, --embedder-url, and --embedder-model. The provider is ollama (default) or llama.cpp; URL and model default per provider.
  • Move the config file settings under an [embedder] table (provider, url, model). Env vars follow, e.g. ANNA_EMBEDDER_PROVIDER, ANNA_EMBEDDER_URL.
  • Change Dependencies.NewEmbedder to take the provider and return an error; unknown providers fail with unsupported embedder.
  • recall resolves embedder settings only for modes that need embeddings, so --mode bm25 ignores an invalid provider.
  • Document llama.cpp usage and provider defaults in the README.

After, from ## Evidence:

nrem / recall → resolveEmbedderSettings → deps.NewEmbedder(provider, url, model)
                                            ├ ollama    → ollama adapter
                                            └ llama.cpp → POST {url}/v1/embeddings

Across four PRs (#164, #167, h3y6e/anna#7, h3y6e/anna#13), bodies written with this branch copied 0 diff lines, and the wording-only #167 omitted ## Evidence.

Impact

Two-way door: only agent instructions change.

🤖 Generated with Claude Code

@h3y6e
h3y6e force-pushed the feat/git-shipping-pr-body-content branch from 35d8248 to c526161 Compare October 15, 2026 19:07
@h3y6e h3y6e changed the title feat(git-shipping): define what each PR body section must show feat(git-shipping): define PR body as Summary, Evidence, Impact Oct 15, 2026
@h3y6e
h3y6e force-pushed the feat/git-shipping-pr-body-content branch from c526161 to 92752e7 Compare October 15, 2026 19:13
intent(pr-body): a reviewer should grasp the change without reading the diff
decision(pr-body): Evidence shows before/after as trees or pseudocode, never copied diff lines, and is omitted for small diffs
rejected(pr-body): separate Background and Changes sections, since Changes drifted into file-by-file lists
learned(gh): gh pr create/edit --attach uploads images; GitHub strips inline svg and data URIs
learned(mermaid): layout reorders nodes and crosses edges, so text blocks are the default view

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@h3y6e
h3y6e force-pushed the feat/git-shipping-pr-body-content branch from 92752e7 to 7a1b0bf Compare October 15, 2026 19:28
@h3y6e
h3y6e marked this pull request as ready for review October 15, 2026 19:30
@h3y6e
h3y6e merged commit a6fc1e6 into main Oct 15, 2026
1 check passed
@h3y6e
h3y6e deleted the feat/git-shipping-pr-body-content branch October 15, 2026 19:31
@heyhoe-releaser heyhoe-releaser Bot mentioned this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant