Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A retaining
downcan leave an admitted graph partially stopped. The frontend previously sent that pending shutdown through failed-start recovery, where a completed historical startup journal caused a refusal without useful diagnostics. This change preserves the mapping, reports bounded service/stage diagnostics, and adds read-onlydoctor --native-cleanup inspectoutput with the supported explicit recovery flow.Immediate-successor recovery now recognizes the interrupted operation’s exact pre-effect bridge selection, including graphs with no ingress routes. Empty selections still require a verified dead predecessor; historical generations still require independent restore-history proof. Same-boot uncertain stop requests are not replayed.
Validation on isolated Apple Silicon macOS pools:
51188903e3b5625d9af7f117cf8b492bf0820a80(run). Privacy and generated CLI-reference checks passed.The original published
engine_protocolfailure cause remains unproven. Native fixtures are ignored by ordinary CI and require explicit isolated pools/watchdogs; this PR does not claim new application acceptance, comparative performance gains, or an updated published prerelease. Private logs/research are excluded.Tracks HACK-1212. Candidate base:
next.Hosted Linux lint initially found an unused plain stop wrapper. It is now compiled only for its macOS recovery callers; diagnosed graph shutdown remains available on both platforms. Local default/all-feature clippy and final-head Linux/macOS CI pass.