fix: retain safe native dependency refresh diagnostics - #129
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dependency refresh failed before native
hack execorhack run, the frontend discarded the runtime's structured error identifiers and reported only an unconfirmed outcome. This made an isolated linked-worktree qualification failure impossible to diagnose from its retained CLI output.Preserve only explicitly reviewed, value-free identifiers from
NativeRuntimeRequestError, including known nested cause codes. Unknown identifiers, ordinary errors, forged fields, raw messages, paths and input remain omitted. The existing refusal, one request, no replay, and refresh-before-command boundary are unchanged.Validation: 23 focused refresh/exec/one-off tests passed; changed source/test lint, CLI typecheck and lint, full repository typecheck/check and staged privacy checks passed. Full repository tests passed: CLI 1,827 passed, 67 skipped, zero failures. CLI tasks executed; database tasks were cached.
Release signal:
fix, diagnostic-only. This does not fix or identify the original native refresh failure, authorize retry, or establish fresh native application acceptance. The retained uncertain fixture was not mutated. A fresh supervised qualification run is the next diagnostic gate.Discovered while qualifying HACK-1163; separate from the domain harness in #128. Base: protected
next.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.