Conversation
roodboi
marked this pull request as ready for review
October 5, 2026 02:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an exact HTTPS lease release is refused, the owner currently closes its socket and hides the failing check. Return a bounded failure response with the complete lease identity, a fixed release stage, and an allowlisted native code. The CLI reports this value-free diagnostic while leaving cleanup unconfirmed.
No mutation is replayed, and no diagnostic counts as retirement or grants replacement authority. Existing release checks and effect order remain unchanged. Private protocol frames must round-trip through their existing encoder; duplicate/extra fields, foreign identities and malformed replies cannot become successful release acknowledgements.
Dependency: includes the test-only correction from #132 (original commit
1579a099, cherry-picked as25e5975a). Until #132 merges, this PR depends on it. The correction obtains the actual child from the parent spawn result and verifies exit completion,SIGKILL, and PID absence when the deadline occurs before the child writes a marker. Production timeout behavior and budgets are unchanged.Validation on
25e5975a: 75 focused controls pass (detached owners, exact release diagnostics, socket refusal/no-replay behavior, and runtime-client cancellation). The single new full CLI run passed: 1,876 passed, 67 skipped, zero failures, 8,814 assertions. Root typecheck/check, changed-test lint, privacy and diff checks also pass with pinned Bun 1.4.2. CLI gates ran fresh; unchanged DB tasks used the shared cache. Independent review of the diagnostic implementation and the test correction found no actionable issue.Earlier full runs failed the unchanged cancellation test because its 250 ms deadline could expire before the child wrote its marker. Both failure logs remain retained. The separate #132 correction addresses that test assumption; it does not fix the native HTTPS release failure.
Separate integrated qualification combined this change with the authority-startup correction in #133 and the test correction in #132. That local composite passed all 54 domain-migration/rollback checks and verified owned fixture disposal (frontend source
d67f4a9d, native sourcee3f3d07b, harness4548f6a8). This is evidence for that composite only; it does not show that standalone #131 fixes the failure, and it does not qualify system DNS, browser trust, performance or a published build.Release signal:
fix. This is a diagnostic correction. Broader domain/browser acceptance remains tracked under HACK-1163.