Corrected ranking in caprieval for reverse sorting - Issue #1621#1622
Merged
Conversation
AnnaKravchenko
approved these changes
Jul 13, 2026
Contributor
There was a problem hiding this comment.
Sorting is working as expected now - checked for 'score' and ‘fnat’ metrics, both in caprieval and caprifilter.
Also, I found out this bug was introduced by me while moving the sorting function from capri.py to libcapri.py:( Nice it was spotted and resolved quickly!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Corrected
libcapri.pyso that whensort_ascending=falsethecaprieval_rankreported incapri_ss.tsvmatch the actually sorting of the fileAdded a test for this.
How was this tested?
By running a test example from the docking-protein-protein example, adding
sort_ascending=falseto a caprieval module and check that thecaprieval_ranksare matching the sort order.AI assistance
AI was used to add the test
Checklist
CHANGELOG.mdupdated for user-facing changesRelated issues
#1621
Notes for reviewers
Note that the reranking is only affecting the single structure analysis reported in
capri_ss.tsvBetter not to change the reported
cluster_rankin thecapri_clt.tsvfile as this rank corresponds to the cluster naming. In this case, the reverse sorting should be enabled directly in theseletopclustmodule (see issue #1620)