renovate.json: recognize sbt's scalaVersion := syntax - #14
Merged
Conversation
The "Scala language version" customManager matched scala-cli's `//> using scala` and Mill's `def scalaVersion =`, but not sbt's `scalaVersion := "..."` — every repo's README documents all three build tools, so the sbt install snippet was silently exempt from every scala3 bump. Confirmed on halotukozak-com/mrpc#55 (open): it updates the scala-cli and mill blocks to 3.9.0 but leaves the sbt block at 3.9.0-RC4 untouched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ADME.md there) made and alpaca's README.md is a symlink to docs/_docs/index.md (their docs site's index page doubles as the README). That's very likely why halotukozak-com/made#145 bumped project.scala's scala3 version but never touched the README: Renovate almost certainly reads the real file when it matches README.md at path level, but writing the substitution back through a symlink is a different story, and made's docs/_docs/index.md is still stuck at 3.9.0-RC4 across all three install snippets right now. Matching the real path directly should let Renovate write straight to it instead of through the symlink. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
halotukozak
added a commit
to halotukozak-com/mcodec
that referenced
this pull request
Aug 31, 2026
…on mention The sbt snippet's scalaVersion := "3.9.0-RC4" never got bumped alongside the scala-cli/mill ones -- Renovate's regex customManager didn't match sbt's `:=` syntax (fixed in halotukozak-com/.github#14). Also: - `def mvDeps` -> `def mvnDeps` (Mill's actual field name) - the top caveat's "3.9.0-RC4"/"made_3:0.1.2" mention (free prose, not something any regex manager touches) vs. project.scala's actual `made::0.4.1` dependency Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two Renovate gaps found while investigating why README install snippets go stale:
1. sbt's
scalaVersion := "..."syntax was never matched. Every repo's README documents scala-cli, sbt, and Mill install snippets. The "Scala language version"customManageronly matched scala-cli's//> using scalaand Mill'sdef scalaVersion =— sbt'sscalaVersion := "..."(note the:=, not=) never matched, so that snippet silently never got bumped along with the other two.Confirmed live on mrpc#55 (open): it bumps the scala-cli and mill blocks in README.md to
3.9.0, plusproject.scala, but leavesscalaVersion := "3.9.0-RC4"untouched. Same gap present inmcodec's README right now.2.
madeandalpaca'sREADME.mdis a symlink todocs/_docs/index.md. That's very likely whymade#145bumpedproject.scala's scala3 version but never touched the README at all (not even the two snippets the first fix above doesn't need) — Renovate matches the pathREADME.md, but writing the regex substitution back through a symlink is a different story.made'sdocs/_docs/index.mdis stuck at3.9.0-RC4across all three install snippets right now (manually fixed in a companion PR). Addeddocs/_docs/index.mdto everymanagerFilePatternslist that already hadREADME.md, so Renovate can target the real file directly.Test plan
🤖 Generated with Claude Code