Document further commons RPC gaps (D9-D17) + reject inert @tagged/@methodTag/@paramTag (D10) - #3
Closed
halotukozak wants to merge 2 commits into
Closed
Conversation
This was referenced Aug 8, 2026
3 tasks
Ported a feature-by-feature comparison against the actual AVSystem/scala-commons rpc/meta source (fully generic raw-method framework, tag-driven routing, interceptors, @tried, ADT metadata, reflective metadata richness, Fallback/ MacroInstances) and catalogued each confirmed gap the same way D1-D8 already do. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
They compiled and silently did nothing under mrpc's fixed fire/call/get RawRpc (no tag-selection branch exists to steer, D9) — a landmine, not a no-op. hasAnnotation[X[?]] guards in Plans.materialize (trait-level @methodTag/@paramTag) and OpPlan.materialize/ParamPlan.encodingOf (method-/param-level @tagged) turn that into a compile error instead. The wildcard type arg matches every instantiation despite these annotations being invariant in their type parameter. Real tag-driven routing still needs the generic raw-method framework (D9); this closes only the silent-no-op landmine, not the underlying gap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
halotukozak
force-pushed
the
d10-tag-guard-compile-error
branch
from
August 9, 2026 09:05
bde63f5 to
06d3610
Compare
This was referenced Aug 10, 2026
Open
Collaborator
Author
halotukozak
added a commit
that referenced
this pull request
Aug 10, 2026
Mirrors commons Fallback[T]: wraps a value to lower its implicit priority below normal givens, via a fromFallback given at the bottom of each typeclass's priority chain. A Fallback-wrapped instance resolves only when nothing else does; a normal given always wins, no ambiguity. DIVERGENCES.md's D17 entry will be updated once the D9-D17 doc PR (#3) merges, since this branch predates it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
halotukozak
added a commit
that referenced
this pull request
Aug 10, 2026
Mirrors commons Fallback[T]: wraps a value to lower its implicit priority below normal givens, via a fromFallback given at the bottom of each typeclass's priority chain. A Fallback-wrapped instance resolves only when nothing else does; a normal given always wins, no ambiguity. DIVERGENCES.md's D17 entry will be updated once the D9-D17 doc PR (#3) merges, since this branch predates it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DIVERGENCES.mdwith D9-D17: a feature-by-feature comparison against the actual AVSystem/scala-commonsrpc/metasource (fully generic raw-method framework, tag-driven routing, interceptors,@tried, ADT metadata, reflective metadata richness,Fallback/MacroInstances).@tagged/@methodTag/@paramTagused to compile and silently do nothing under mrpc's fixed fire/call/getRawRpc(no tag-selection branch exists to steer, per D9). They're now a compile error instead, viahasAnnotation[X[?]]guards inPlans.materialize(trait-level@methodTag/@paramTag) andOpPlan.materialize/ParamPlan.encodingOf(method-/param-level@tagged).test/mrpc/parity/TagAnnotationsRejectedSuite.scalalocking in the new compile-error behavior for all three annotations, at both method and param position.Real tag-driven routing still needs the generic raw-method framework (D9); this only closes the silent-no-op landmine, not the underlying gap. Next candidates from the D9-D17 list can follow as separate PRs.
Test plan
Run CIworkflow)scala-cli test . --test-only 'mrpc.parity.TagAnnotationsRejectedSuite'passes locallymrpc.parity.*/mrpc.derive.*/mrpc.annotation.*suites🤖 Generated with Claude Code