Repository navigation
[misc] Remove incidental comments merged into main - #2082
Open
fv-superagent wants to merge 4 commits into
Open
fv-superagent wants to merge 4 commits into
fv-superagent wants to merge 4 commits into
Conversation
Contributor
Merge Protections🔴 1 of 3 protections blocking · waiting on 👀 reviews and 🤖 CI
🔴 PR merge requirementsWaiting for
This rule is failing.
Show 2 satisfied protections🟢 📃 Configuration Change RequirementsMergify configuration change
🟢 MLX smoke requirements
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is by an automated agent, not a human.
Problem:
mainhas accumulated incidental comments across every language it ships — narration that restates the next line, decorative banners and# ----dividers, commented-out code, link-lessTODO/FIXME/HACKmarkers and "for now" notes. They arrive in routine PRs rather than with any one change, so there is no tracking issue; a maintainer asked for a repo-wide sweep. Every later diff carries the noise.Change: removes 2,869 lines net across 403 files (
git diff --shortstat main: 403 files changed, 67 insertions, 2,936 deletions). The 67 insertions are the unchanged code halves of inline trailing-comment removals. Every comment-bearing tracked text file was scanned — 2,300 files across Python, shell/Slurm, YAML/TOML, TypeScript/TSX/JS/CSS, CUDA/C++, Markdown and Dockerfiles — and 403 needed edits. No code, string literal, docstring, import, configuration value or formatting change. Kept: license and attribution headers; tool directives (# noqa,# type: ignore,# shellcheck,# yamllint,// eslint-disable,// @ts-ignore,# pragma); URLs and issue links; public API docstrings; and comments documenting a non-obvious constraint (CUDA/vendor/version behavior, checkpoint formats, numerical guarantees, distributed invariants, "matches upstream X"). Excluded: vendoredfastvideo/third_party/, submodule gitlinks (fastvideo-kernel/include/{cutlass,tk}), binary assets, lockfiles, and.github/workflows/**.Verification:
main; Python files are additionallyast.dump-identical;.toml/.jsonparse to equal structures; no removed line falls inside a YAML block scalar; no added line carries trailing whitespace. Result:changed files=403 styled=403 problems=0.pre-commit run --files <paths>could not run locally: the pre-commit store directory is read-only and the hook repositories cannot be fetched (no DNS). The GitHubpre-commitcheck is the lint gate; an earlier run flagged yapf blank lines that comment deletion had merged, which this branch realigns..pre-commit-config.yamlexcludes most touched paths (fastvideo/models/,fastvideo/dataset/,scripts/,examples/,fastvideo/tests/,fastvideo-kernel/,apps/dreamverse/web/), so "(no files to check)" is intentional there.d945cc79: the GitHubpre-commitcheck passed (run) and Buildkite pr-fastcheck build 2286 passed all six lanes —microscope-{unit,kernel,dreamverse-app,encoder,vae,transformer}-tests— andfastcheck-passed.Risk: Comment-only, so no numerical output, public API or CI behavior change; the diff does touch
fastvideo-kernel/and the repo's own.pre-commit-config.yaml,.github/mergify.ymland.buildkite/scripts/pr_test.sh, but only by deleting comment lines — no build input, configuration value or command changed. The one theoretical risk is a deleted comment that carried intent; behavior-forced comments, suppression directives, links and public docstrings were preserved, and vendored files were skipped..github/workflows/**was left untouched.— fv-superagent · The comments are gone; behavior didn't move. · run by aryan5v