Skip to content

[misc] Remove incidental comments merged into main - #2082

Open
fv-superagent wants to merge 4 commits into
mainfrom
agent/comment-sweep-10f44f7294e7
Open

fv-superagent wants to merge 4 commits into
mainfrom
agent/comment-sweep-10f44f7294e7

Conversation

@fv-superagent

@fv-superagent fv-superagent commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

This is by an automated agent, not a human.

Problem: main has accumulated incidental comments across every language it ships — narration that restates the next line, decorative banners and # ---- dividers, commented-out code, link-less TODO/FIXME/HACK markers and "for now" notes. They arrive in routine PRs rather than with any one change, so there is no tracking issue; a maintainer asked for a repo-wide sweep. Every later diff carries the noise.

Change: removes 2,869 lines net across 403 files (git diff --shortstat main: 403 files changed, 67 insertions, 2,936 deletions). The 67 insertions are the unchanged code halves of inline trailing-comment removals. Every comment-bearing tracked text file was scanned — 2,300 files across Python, shell/Slurm, YAML/TOML, TypeScript/TSX/JS/CSS, CUDA/C++, Markdown and Dockerfiles — and 403 needed edits. No code, string literal, docstring, import, configuration value or formatting change. Kept: license and attribution headers; tool directives (# noqa, # type: ignore, # shellcheck, # yamllint, // eslint-disable, // @ts-ignore, # pragma); URLs and issue links; public API docstrings; and comments documenting a non-obvious constraint (CUDA/vendor/version behavior, checkpoint formats, numerical guarantees, distributed invariants, "matches upstream X"). Excluded: vendored fastvideo/third_party/, submodule gitlinks (fastvideo-kernel/include/{cutlass,tk}), binary assets, lockfiles, and .github/workflows/**.

Verification:

  • Per-language comment-only proof over all 403 changed files: the non-blank content after stripping that language's comments equals main; Python files are additionally ast.dump-identical; .toml/.json parse to equal structures; no removed line falls inside a YAML block scalar; no added line carries trailing whitespace. Result: changed files=403 styled=403 problems=0.
  • pre-commit run --files <paths> could not run locally: the pre-commit store directory is read-only and the hook repositories cannot be fetched (no DNS). The GitHub pre-commit check is the lint gate; an earlier run flagged yapf blank lines that comment deletion had merged, which this branch realigns. .pre-commit-config.yaml excludes most touched paths (fastvideo/models/, fastvideo/dataset/, scripts/, examples/, fastvideo/tests/, fastvideo-kernel/, apps/dreamverse/web/), so "(no files to check)" is intentional there.
  • pytest is not installed in this environment and the change is comment-only, so no test exercises it; the per-language content check is the behavior guard and the Fastcheck lanes cover the code paths.
  • CI on d945cc79: the GitHub pre-commit check passed (run) and Buildkite pr-fastcheck build 2286 passed all six lanes — microscope-{unit,kernel,dreamverse-app,encoder,vae,transformer}-tests — and fastcheck-passed.

Risk: Comment-only, so no numerical output, public API or CI behavior change; the diff does touch fastvideo-kernel/ and the repo's own .pre-commit-config.yaml, .github/mergify.yml and .buildkite/scripts/pr_test.sh, but only by deleting comment lines — no build input, configuration value or command changed. The one theoretical risk is a deleted comment that carried intent; behavior-forced comments, suppression directives, links and public docstrings were preserved, and vendored files were skipped. .github/workflows/** was left untouched.

— fv-superagent · The comments are gone; behavior didn't move. · run by aryan5v

@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 1 of 3 protections blocking · waiting on 👀 reviews and 🤖 CI

Protection Waiting on
🔴 PR merge requirements 👀 reviews and 🤖 CI
🟢 📃 Configuration Change Requirements —
🟢 MLX smoke requirements —

🔴 PR merge requirements

Waiting for

  • #approved-reviews-by>=1
  • check-success=full-suite-passed
This rule is failing.
  • #approved-reviews-by>=1
  • check-success=full-suite-passed
  • check-success=fastcheck-passed
  • check-success~=pre-commit
  • title~=(?i)^\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\]

Show 2 satisfied protections

🟢 📃 Configuration Change Requirements

Mergify configuration change

  • any of:
    • check-success = @mergify/Configuration changed
    • check-success = @mergify/Configuration has been deleted

🟢 MLX smoke requirements

  • check-success=mlx-smoke
  • check-success=mlx-smoke-linux-cpu

@mergify mergify Bot added type: misc Cleanup, config, dependencies scope: training Training pipeline, methods, configs scope: inference Inference pipeline, serving, CLI scope: attention Attention backends (VSA, STA, Flash, etc.) scope: data Data preprocessing, datasets scope: infra CI, tests, Docker, build scope: distributed SP, FSDP, USP, multi-node scope: studio scope: model Model architecture (DiTs, encoders, VAEs) labels Nov 10, 2026
@mergify mergify Bot added scope: kernel CUDA kernels, fastvideo-kernel scope: docs Documentation labels Nov 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: attention Attention backends (VSA, STA, Flash, etc.) scope: data Data preprocessing, datasets scope: distributed SP, FSDP, USP, multi-node scope: docs Documentation scope: inference Inference pipeline, serving, CLI scope: infra CI, tests, Docker, build scope: kernel CUDA kernels, fastvideo-kernel scope: model Model architecture (DiTs, encoders, VAEs) scope: studio scope: training Training pipeline, methods, configs type: misc Cleanup, config, dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants