Repository navigation
Conversation
This was referenced Oct 7, 2026
behdad
added this pull request to stack #518
October 8, 2026 06:10
7 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subset coverage currently runs locally while CI exercises only one C smoke case. Add all three differential suites to Linux CI: 48 Skia workflow cases, 15 input/flag cases, and 16 plan/map cases, with their additional lifetime, metadata, callback, and failure checks. Build the HarfBuzz reference at a fixed commit with optional backends disabled and pin fontTools for reproducibility.
Add a native Windows job that builds default and subset-enabled versions of the single
harfrust_cDLL and executes actual C and C++ consumers. Core-only tests link the default build; subset tests link the feature-enabled build. The C++ checks cover C++11/C++17 on Linux/macOS and C++14/C++17 with the MSVC standard library, core-only linking, both subset include orders, shared handles, ownership, and user-data destruction.Validation: all 79 differential cases pass against a fresh HarfBuzz reference build. The single Windows GNU DLL with
subsetenabled builds and links; its C subset example and all six C++11/C++17 variants execute successfully under Wine. Updated Linux, macOS, and native Windows CI are running.Stacked on #514; follows #507.