Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementation correctly addresses the reported ambiguity and includes comprehensive regression coverage.
0 open findings
What changed in this PR
Fixes issue #208 by distinguishing explicit Unix-epoch JWT time claims from missing claims.
Changes:
- Uses nil checks when deriving and validating time claims.
- Adds epoch-zero, missing, and null claim tests.
- Documents the corrected behavior.
| File | Description |
|---|---|
jwt/jwt.go |
Preserves explicit zero-value time claims. |
jwt/time_claims_test.go |
Tests time-claim presence and derivation. |
jwt/README.md |
Documents time-claim semantics. |
CHANGELOG.md |
Records the bug fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
swayne275
force-pushed
the
swayne/fix-issue-208
branch
from
October 8, 2026 21:51
275fa3a to
5ce007d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCI review checklist
only derive nbf/iat if not provided (rather than provided but 0)
fixes issue 208
once this merges we should cut a new release so downstream products can update
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.