-
Notifications
You must be signed in to change notification settings - Fork 122
FE-1222, FE-1226: Classify optimization transport errors, auto-reconnect runs by id + cursor, and remove the legacy optimization path #9066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kube
wants to merge
27
commits into
main
Choose a base branch
from
cf/fe-1226-petrinaut-optimization-reconnect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
15022b9
FE-1224: Add detached, reconnectable optimization runs to the Petrinaβ¦
kube a23b8b0
FE-1224: Address review β bound the run engine and fix attach edge cases
kube 8b1c6a9
FE-1225: Proxy detached Petrinaut optimization runs through NodeAPI
kube c79703e
FE-1225: Address review β share admission state and harden ownership
kube cf08515
FE-1222: Classify Petrinaut optimization transport errors in the UI
kube decea70
FE-1226: Auto-reconnect Petrinaut optimization streams by run id and β¦
kube d36b63d
FE-1226: Align detached-run flow with the NodeAPI contract
kube 469d5b1
FE-1226: Address review β cancel orphaned runs and honest reconnect sβ¦
kube d2b42dd
Merge branch 'backend-consolidated' into frontend-cutover
kube 9f93e27
FE-1226: Remove the legacy single-connection optimization path
kube 691d81a
FE-1225: Drop the legacy streaming optimize route from NodeAPI
kube c07fb78
FE-1224, SRE-810: Keep the events attachment out of the RED latency SLIs
kube 2c4fae2
Merge branch 'backend-consolidated' into frontend-cutover
kube 94d374a
FE-1224, FE-1225: Address review β end superseded attachments cleanlyβ¦
kube 7fcbd4a
Merge branch 'backend-consolidated' into frontend-cutover
kube a32969e
FE-1222, FE-1226: Address review β classify demo stream errors and haβ¦
kube 9ebf1d5
FE-1225: Factor the shared optimization route preamble
kube fa2058c
Merge branch 'backend-consolidated' into frontend-cutover
kube 1848a8c
FE-1224, FE-1225: Move run ownership into the optimizer and thin Nodeβ¦
kube dcb0fa1
Merge branch 'backend-consolidated' into frontend-cutover
kube 1292a65
FE-1226: Alias the demo's openapi-fetch verb methods for oxlint's newβ¦
kube 838808c
FE-1226: Bump petrinaut packages as patch, not minor
kube 78bc356
FE-1225: Keep cancel off the create rate bucket
kube 3764187
Merge branch 'backend-consolidated' into frontend-cutover
kube 8abd688
FE-1226: Report a created run as running before its first event
kube 8808b14
FE-1226: Allow the quiet-run test's yield-less attachment generator
kube 79c0b6f
FE-1226: Address review β classify attach-time drops and keep stored β¦
kube File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@hashintel/petrinaut-core": patch | ||
| "@hashintel/petrinaut": patch | ||
| --- | ||
|
|
||
| Make optimization runs detached and resumable β and make that the only contract. Optimization events carry a server-issued `seq`; the host optimization capability is now `createOptimizationRun`/`attachOptimizationRun`/`cancelOptimizationRun` (all required; attachments accept an `onAttached` callback so UIs can report an honest connection state), and the legacy single-connection `optimize` method is removed. The optimizations UI auto-reconnects dropped event streams by run id and cursor, re-attaching after page reloads where storage allows. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashintel/petrinaut-core": patch | ||
| --- | ||
|
|
||
| Add an optional `seq` sequence number to every optimization event so detached, reconnectable optimization runs can be resumed from a cursor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.