Allow case insensitive bools#11828
Conversation
4e15a9c to
c846c51
Compare
|
@philderbeast You often make pull requests like this, I'm interested in your opinion on this matter. |
c846c51 to
03d13bf
Compare
tdammers
left a comment
There was a problem hiding this comment.
LGTM; comments are not show stoppers, just things I think would be worth considering.
03d13bf to
01a59e7
Compare
|
@tdammers thanks for your feedback! |
8e1d6a7 to
2bbe4e7
Compare
Mikolaj
left a comment
There was a problem hiding this comment.
Could you please clarity what this PR does about -O1 and why (I know it's in the code, but the motivation is not)? How does this relate to the changes from 2008? Thank you!
|
2bbe4e7 to
5d77f4f
Compare
Mikolaj
left a comment
There was a problem hiding this comment.
Thank you for the explanation of the motivation. Makes sense. Would it also make sense to split the -O1 change to a separate PR? Or to a separate commit in this PR?
BTW, does github display it wrong or is the commit "Add NoFlagValue type class" deleting a lot of files?
2579697 to
6ca7382
Compare
|
@Mikolaj sorry i try to switch from git to jj and some how lost |
what is the “change” exactly? I still don’t see an answer to Mikolaj’s question above:
And I’d like to see this answered in the PR description and the changelog, if there’s a change in behavior (and the commit message, perhaps; it can be a copy-paste). In particular, Is there a change in cabal’s behavior or is it a pure refactoring? |
38646dd to
c94287f
Compare
|
@ulysses4ever Sorry, you're right, I misread it. I'll make a separate PR. You're right, it's a refactoring, that's why I chose template B. I assume |
The
.cabalfile parser now accepts boolean values in a case‑insensitive manner (true,True,TRUE,false, etc.) without emitting a warning.Previously only
TrueandFalsewere treated as “standard”, and other capitalisations triggered a parse warning. That warning was introduced in 2008 as a backwards‑compatibility shim to prevent Hackage uploads that would break very old Cabal versions. Since all supported Cabal releases can now handle case‑insensitive booleans, the warning has been removed as unnecessary.origin commit in 2008: e92d6573#r185301031
research done by @jappeace: https://github.com/haskell/cabal/pull/11716/changes#r3243914138
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: