Handle closed report channel without panic#885
Open
tyr1k wants to merge 1 commit into
Open
Conversation
ahmed-mekky
reviewed
Jun 18, 2026
| set_start_latency_correction(&mut res, start_latency_correction); | ||
| } | ||
| report_tx.send(res).unwrap(); | ||
| if !try_send_report(report_tx, res) { |
Contributor
There was a problem hiding this comment.
why didn't you just do
if !report_tx.send(res).is_ok() {the function looks like an unneeded layer of abstraction here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workers can outlive the report receiver during early shutdown/deadline paths.
When the receiver is closed, kanal returns ReceiveClosed. This is expected
during shutdown and should stop the worker instead of panicking via unwrap().
When the report receiver is closed, workers stop as if cancellation was requested.
Fixes #883