Skip to content

ci(commitlint): stop failing on long trailer lines after an issue reference - #4868

Open
chopratejas wants to merge 1 commit into
mainfrom
ci/commitlint-footer-length
Open

chopratejas wants to merge 1 commit into
mainfrom
ci/commitlint-footer-length

Conversation

@chopratejas

@chopratejas chopratejas commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Description

commitlint (config-conventional) treats a commit-body line that mentions an issue (#1234) as the start of the footer. The repo's required Assay-Ask: trailer that follows is then checked against footer-max-line-length (100) and fails, so a commit like "merge main into the branch, picks up #4835" fails commitlint even though its subject and type are fine. body-max-line-length is already disabled; this disables the footer limit the same way.

Because the commitlint job checks out the PR merged with main, this also clears the failure on open PRs on their next run.

Type of Change

  • CI / build config

Changes Made

  • .commitlintrc.json: "footer-max-line-length": [0].

Testing

Ran @commitlint/cli@19 with @commitlint/config-conventional@19 on a message with an issue reference in the body and a 150-character Assay-Ask: trailer:

main's config:
✖   footer's lines must not be longer than 100 characters [footer-max-line-length]
✖   found 1 problems, 0 warnings
exit=1

this branch:
exit=0

Real Behavior Proof

  • Environment: macOS, Node 26, @commitlint/cli@19.
  • Steps: the command above, against both config files.
  • Observed: the old config rejects the message; the new config accepts it. The type, subject and other rules are unchanged.

🤖 Generated with Claude Code


Devin Review

…erence

commitlint treats a body line that mentions an issue as the start of the
footer, so the required Assay-Ask trailer that follows it is checked
against the 100-character footer limit and fails. Body lines are already
unlimited; footer lines now are too.

Assay-Kind: config
Assay-Ask: Commitlint failed PRs whose commit body mentioned an issue number before a long required trailer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chopratejas chopratejas added size: small At most 100 added/deleted lines. risk: low Scope estimate: documentation/tests-only change; verification still required. area: ci Touches ci files; triage routing, not a CODEOWNERS assignment. labels Nov 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR governance

This PR does not yet satisfy the required template fields:

  • Missing required section Runtime Rollout Safety.
  • Missing required section Review Readiness.
  • Check at least one verification item in Testing.
  • Fill in Real Behavior Proof → Exact command / steps.
  • Fill in Real Behavior Proof → Observed result.
  • Fill in Real Behavior Proof → Not tested.
  • Check I have performed a self-review before requesting human review.
  • Check This PR is ready for human review or convert the PR back to draft.

Please update the PR body, or move the PR back to draft while it is still in progress.

@github-actions github-actions Bot added the status: needs author action Pull request body or readiness checklist still needs author updates label Nov 13, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread .commitlintrc.json Resolved

This branch was successfully deployed

1 active deployment
Preview — ce498e6b Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci Touches ci files; triage routing, not a CODEOWNERS assignment. risk: low Scope estimate: documentation/tests-only change; verification still required. size: small At most 100 added/deleted lines. status: needs author action Pull request body or readiness checklist still needs author updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant