Skip to content

gh-423: Factorize jackknife_cls for parallelism#424

Merged
ucapbba merged 12 commits into
mainfrom
pipe_updates
Jul 3, 2026
Merged

gh-423: Factorize jackknife_cls for parallelism#424
ucapbba merged 12 commits into
mainfrom
pipe_updates

Conversation

@ucapbba

@ucapbba ucapbba commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

fixes: #423

The jackknife_cls method has been factorized into individual methods _compute_single_jk_alm _compute_single_jk_cls. For now the old jackknife_cls has been renamed to jackknife_cls_old should any additional comparison be required.

I have tested both methods are the same by comparing the cls for delete 1 and delete 2 (notebook available on demand). I have also implemented the individual methods in a fully parallel setup, giving significant performance improvement.

@ucapbba ucapbba requested review from JaimeRZP and ntessore July 1, 2026 18:16
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
heracles/dices/jackknife.py 86.20% 8 Missing ⚠️
Flag Coverage Δ
py3.10 83.40% <86.20%> (+0.02%) ⬆️
py3.11 83.40% <86.20%> (+0.02%) ⬆️
py3.12 83.36% <86.20%> (+0.02%) ⬆️
py3.13 82.94% <86.20%> (+0.03%) ⬆️
py3.9 83.60% <85.96%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
heracles/dices/jackknife.py 95.25% <86.20%> (-0.77%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread heracles/dices/jackknife.py Outdated
@ucapbba

ucapbba commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Hey @JaimeRZP, thanks for your suggestions. I have removed the old code and removed any updates to init.py. The ipynb should run without needing any changes.

@JaimeRZP

JaimeRZP commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@ucapbba All good and checked the notebook runs as usual

@ucapbba ucapbba removed the request for review from ntessore July 2, 2026 15:51
@ucapbba

ucapbba commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@JaimeRZP - that's great. Could you approve so I can merge? I guess Nicolas won't have time.

Comment thread heracles/dices/__init__.py Outdated
Comment thread heracles/dices/__init__.py Outdated
@ucapbba ucapbba merged commit b7e9d3a into main Jul 3, 2026
10 checks passed
@ucapbba ucapbba deleted the pipe_updates branch July 3, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Factorize jackknife_cls for parallelism

2 participants