-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Saved-machine panes are laid out one row taller than the local viewport, so the bottom row is clipped (0.9.1) #4614
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingmaintainer-neededrequires maintainer judgment or maintainer-only reproductionrequires maintainer judgment or maintainer-only reproductionp2valid narrow or ordinary defect with limited impact or a practical workaroundvalid narrow or ordinary defect with limited impact or a practical workaroundremoteaffects SSH, headless, or remote attachment behavioraffects SSH, headless, or remote attachment behaviorrenderingterminal emulation, reflow, layout, graphics, or output renderingterminal emulation, reflow, layout, graphics, or output renderingtriagedScreened; left open for investigation or maintainer judgment. Not proof of a bug or reproduction.Screened; left open for investigation or maintainer judgment. Not proof of a bug or reproduction.
Description
Activity
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingmaintainer-neededrequires maintainer judgment or maintainer-only reproductionrequires maintainer judgment or maintainer-only reproductionp2valid narrow or ordinary defect with limited impact or a practical workaroundvalid narrow or ordinary defect with limited impact or a practical workaroundremoteaffects SSH, headless, or remote attachment behavioraffects SSH, headless, or remote attachment behaviorrenderingterminal emulation, reflow, layout, graphics, or output renderingterminal emulation, reflow, layout, graphics, or output renderingtriagedScreened; left open for investigation or maintainer judgment. Not proof of a bug or reproduction.Screened; left open for investigation or maintainer judgment. Not proof of a bug or reproduction.
Is this a reproducible bug?
Setup
herdr machine) throughherdr remote-client-bridgeclient_id=10inherdr-server.log), so no other client is setting the sizeCurrent behavior
The bottom row of every pane in the saved-machine workspace is drawn outside the visible area. With Claude Code, the footer line under the prompt is missing. Local panes are not affected.
The remote server lays out one row more than the local client shows:
stty sizereturns64 219herdr api snapshotreports the layoutareaasheight: 65, width: 219. A pane PTY there returns65 110forstty -F /dev/pts/N size, which is the left half of a vertical splitThe width matches and the height is one row too many.
herdr server reload-configon the remote fixes it for a moment, then the clipping comes back. It seems to return on the next size report from the local client.Expected behavior
The size the local client forwards for a saved-machine view should equal the area that view gets locally, after the local tab bar, borders and other chrome are subtracted. Remote panes should then fit with no rows clipped.
Steps to reproduce
herdr machine add ...stty sizein a local pane with the remote layoutareainherdr api snapshot. The remote height is one row largerherdr server reload-configon the remote. It looks right until the next size report, then clips againSuspected cause
The local tab bar is visible (1 row). The forwarded height seems to still include that row, so the remote lays out for 65 rows while the saved-machine view only has 64. Hiding the local tab bar should make the two heights match, which would confirm it.
Relevant log (remote
herdr-server.log)No other client connected after this, yet the layout area is now 219×65.