fix(windows): detect pi bundled cli

[akbash-bot]

Issue

After updating to Pi 0.84.3 on Windows, Pi opens normally but its pane does not appear in Agents. Its lifecycle reports are accepted, but the pane remains unknown.

Problem

Pi 0.84.3 starts through dist/bundle/cli.js. Herdr recognized the older dist/cli.js entry only, so it treated the final Node process as unrecognized.

How did we fix it?

Herdr now recognizes the exact bundled CLI path inside the official Pi package. The existing CLI path still works. Other package scripts, generic bundle paths, wrong extensions, and paths with trailing components remain unrecognized.

Verification

The captured bundled path returned no agent before the change and returns Pi afterward. All 26 focused process-identification tests pass. All PR checks pass on Linux, macOS, and Windows. Local just check passed formatting, Clippy, and 3517 of 3518 tests; the unrelated live-handoff PID-discovery test still fails even though its log shows the replacement server started.

refs #3186
refs #3205

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4e70533f-9ebc-4df0-96d0-4e02c1a857e0

📥 Commits

Reviewing files that changed from the base of the PR and between 7d56b4c and 8b7d801.

📒 Files selected for processing (1)

• src/detect/mod.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.

---

📝 Walkthrough

Walkthrough

The process detector now recognizes the bundled Pi CLI path with case-insensitive matching. Tests cover bundled Pi, Mastracode, and invalid lookalike paths.

Changes

CLI detection

Layer / File(s)	Summary
Path detection and validation src/detect/mod.rs	The detector recognizes the bundled Pi CLI path while preserving the existing non-bundled layout. Tests cover Mastracode detection and reject non-CLI, unrelated, incorrectly extended, and trailing Pi paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 8b7d8

This localized change adds recognition for Pi’s bundled Windows CLI while preserving existing behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the Windows fix and the Pi bundled CLI detection change.
Description check	✅ Passed	The description explains the Pi 0.84.3 bundled CLI issue, the implemented fix, preserved behavior, scope, and verification results.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}