Skip to content

refactor(base): rename Experimental to Configure#1438

Open
phm07 wants to merge 1 commit into
mainfrom
refactor-experimental-configure
Open

refactor(base): rename Experimental to Configure#1438
phm07 wants to merge 1 commit into
mainfrom
refactor-experimental-configure

Conversation

@phm07

@phm07 phm07 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

For some commands we might want to do more than just mark them as experimental, e.g. change their generated description. This PR renames Experimental to Configure to make it clear that the function can be used to configure all aspects of the command, not only to mark it as experimental.

@phm07 phm07 requested a review from a team as a code owner June 19, 2026 09:21
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.80%. Comparing base (96fb6e3) to head (dda6d6f).

Files with missing lines Patch % Lines
internal/cmd/base/labels.go 0.00% 2 Missing and 2 partials ⚠️
internal/cmd/base/change_protection.go 0.00% 1 Missing and 1 partial ⚠️
internal/cmd/base/create.go 0.00% 1 Missing and 1 partial ⚠️
internal/cmd/base/delete.go 0.00% 1 Missing and 1 partial ⚠️
internal/cmd/base/describe.go 0.00% 1 Missing and 1 partial ⚠️
internal/cmd/base/list.go 0.00% 1 Missing and 1 partial ⚠️
internal/cmd/base/set_rdns.go 0.00% 1 Missing and 1 partial ⚠️
internal/cmd/base/update.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1438   +/-   ##
=======================================
  Coverage   72.80%   72.80%           
=======================================
  Files         300      300           
  Lines       11104    11104           
=======================================
  Hits         8084     8084           
  Misses       2120     2120           
  Partials      900      900           
Flag Coverage Δ
e2e 51.25% <0.00%> (-0.01%) ⬇️
unit 67.74% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phm07 phm07 force-pushed the refactor-experimental-configure branch from 0dd59fd to 0b8d262 Compare June 19, 2026 09:44
@phm07 phm07 force-pushed the refactor-experimental-configure branch from 0b8d262 to dda6d6f Compare June 19, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant