fix(loadgen): update ValkeyAddr → ValkeyAddrs in test fixtures#213
Conversation
main_test.go was missed when PR #199 renamed the config field from ValkeyAddr string to ValkeyAddrs []string, causing a typecheck lint failure on main. https://claude.ai/code/session_01RVazYxcu73oBNFePtSiTMp
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThree test functions in the loadgen test suite are updated to construct the config object using the new ChangesConfig Field Shape Alignment
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
tools/loadgen/main_test.gowas missed when PR feat: Valkey cluster support with room key ensure RPC #199 renamedValkeyAddr string→ValkeyAddrs []stringin theconfigstructtypechecklint failure onmainRoot cause
PR #199 migrated all services from single-node
VALKEY_ADDRto cluster-modeVALKEY_ADDRS. The production code inmain.gowas updated, but the newly-added test filemain_test.go(added by a concurrent PR that landed after #199) used the old field name in three inlineconfigstruct literals.Fix
Applied to all three affected test cases (
TestDispatch_MembersSustained_UnknownPreset,TestDispatch_MembersSustained_RejectsBadShape,TestDispatch_MembersCapacity_RequiresTargetSize).Test plan
make lint— 0 errors after fixmake test SERVICE=tools/loadgen— passeshttps://claude.ai/code/session_01RVazYxcu73oBNFePtSiTMp
Generated by Claude Code
Summary by CodeRabbit