PTAD-239: Add LEPP tile behind feature toggle - #1072
Conversation
Implement Low Earners' Pension Payment (LEPP) tile integration with feature flag control, LEPP connector, service, and test coverage.
…grationSpec RLSInterruptPageSpec and other integration tests were aborting because DefaultLeppConnector injection was failing due to missing low-earners-pensions-payment service port configuration in the test application builder.
…ides RLSInterruptPageSpec disables HmrcModule but needs to provide an explicit binding for LeppConnector (now added by HmrcModule) to avoid injection conflicts.
…r external services LEPP external URLs should use absolute localhost:7504 format (matching taxcalc-frontend, tax-summaries-frontend pattern) for local integration testing, not relative URLs.
owen-gilfellon
left a comment
owen-gilfellon
left a comment
There was a problem hiding this comment.
I think something might have got mixed up when resolving a merge conflict - lots of recent changes being undone!
Suggested some changes for the way the config is specified too, to fit in with standard patterns
| port = 9331 | ||
| timeoutInMilliseconds = 500 | ||
| } | ||
| low-earners-pensions-payment { |
There was a problem hiding this comment.
Also define a low-earners-pensions-payment-frontend, with port 7503
| url = "https://www.gov.uk/government/publications/extension-of-making-tax-digital-for-income-tax-self-assessment-to-sole-traders-and-landlords/making-tax-digital-for-income-tax-self-assessment-for-sole-traders-and-landlords" | ||
| } | ||
| low-earners-pensions-payment { | ||
| start = "http://localhost:7504/accept-your-low-earners-pension-payment/start" |
There was a problem hiding this comment.
Instead of specifying the URL here, add it to ConfigDecorator using the config already specified under micro services... e.g. for tax calc it does:
private lazy val taxCalcFrontendService = servicesConfig.baseUrl("taxcalc-frontend")
lazy val taxCalcPartialLinkUrl = s"$taxCalcFrontendService/tax-you-paid/summary-card-partials"
Follows standard pattern for PTA, and means we just need to update the base URL in each environment's config
| } | ||
| low-earners-pensions-payment { | ||
| start = "http://localhost:7504/accept-your-low-earners-pension-payment/start" | ||
| payments = "http://localhost:7504/accept-your-low-earners-pension-payment/payments" |
There was a problem hiding this comment.
URL is in the LEPP frontend, so for the links, you'll want to define and use a low-earners-pensions-payment-frontend micro service (these links should be using port 7503)
|
|
||
| label.self_assessment=Self Assessment | ||
| label.mtd_for_itsa=Self Assessment and Making Tax Digital for Income Tax | ||
| label.mtd_for_itsa=Making Tax Digital for Income Tax and Self Assessment |
There was a problem hiding this comment.
Should be Self Assessment and Making Tax Digital for Income Tax?
| label.view_manage_your_mtd_for_it=View and manage Making Tax Digital for Income Tax | ||
| label.view_manage_your_mtd_itsa=View and manage your Making Tax Digital for Income Tax or access your Self Assessment tax returns. | ||
| label.view_manage_your_mtd_it=View and manage Making Tax Digital for Income Tax and access Self Assessment. | ||
| label.view_manage_your_mtd_it=View and manage Making Tax Digital for Income Tax, and access Self Assessment. |
| label.access_your_self_assessment=Access your Self Assessment | ||
|
|
||
| title.signed_in_wrong_account.h1=You are not signed in to the right account | ||
| title.signed_in_wrong_account.stop=You are not signed in to the right account. |
There was a problem hiding this comment.
Changes unrelated to ticket - is this correct?
|
|
||
| ptap.support.tab.card.hmrc.online.link.understanding.account=Deall eich Cyfrif Treth Personol | ||
| ptap.support.tab.card.hmrc.online.link.understanding.account.url=/personal-account/support/understanding-your-account | ||
| ptap.support.tab.card.hmrc.online.link.understanding.account.url=https://www.gov.uk/mewngofnodi-cofrestru-gwasanaethau-ar-lein-cthef |
There was a problem hiding this comment.
This is incorrect - introducing regressions. Remove any changes unrelated to PTAD-239
| } | ||
|
|
||
| "return combined MTD/SA tile in myServices for activated online filer with HMRC-MTD-IT when redesign is true" in { | ||
| implicit val request: UserRequest[AnyContent] = |
There was a problem hiding this comment.
Removing unrelated tests?
| document.select("div.hmrc-card p.govuk-hint").text() mustBe "PAYE hint text" | ||
| } | ||
|
|
||
| "render combined Self Assessment and MTD supporting text in the tabular redesign" in { |
There was a problem hiding this comment.
Remove changes unrelated to PTAD-239
| gaLabel = Some("Child Benefit"), | ||
| id = Some("child-benefit"), | ||
| hintText = Option.when(isRedesign)(messages("label.get_help_with_the_cost_of_bringing_up_children")) | ||
| hintText = redesignHint(isRedesign, messages("label.get_help_with_the_cost_of_bringing_up_children")) |
There was a problem hiding this comment.
Lots of unrelated changes
4 participants
Implement Low Earners' Pension Payment (LEPP) tile integration with feature flag control, LEPP connector, service, and test coverage.