Skip to content

Reorder index - #395

Merged
ppeble merged 5 commits into
holidays:masterfrom
toy:reorder-index
Oct 12, 2026
Merged

ppeble merged 5 commits into
holidays:masterfrom
toy:reorder-index

Conversation

@toy

@toy toy commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Originally done to fix a problem for SI, SK and VE having meta regions as their parents. But also to bring order to the index :)

As Europe and SouthAmerica were preceding in index those 3 country codes, code for generating PARENT_REGION_LOOKUP was using those as parents instead of creating a self-reference.

toy added 5 commits October 11, 2026 17:21
Signed-off-by: Ivan Kuchin <tadump+git@gmail.com>
Signed-off-by: Ivan Kuchin <tadump+git@gmail.com>
Signed-off-by: Ivan Kuchin <tadump+git@gmail.com>
Signed-off-by: Ivan Kuchin <tadump+git@gmail.com>
Signed-off-by: Ivan Kuchin <tadump+git@gmail.com>

@ppeble ppeble left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great improvement. Thank you!

@ppeble
ppeble merged commit d40ce7d into holidays:master Oct 12, 2026
9 checks passed
@toy
toy deleted the reorder-index branch October 14, 2026 20:59
toy added a commit to toy/holidays.ics that referenced this pull request Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants