migrator: rename stale deliveries_* pkey indexes to attempts_* - #1031
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
alexbouchardd
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deliveries->attemptstable rename in000005_denormalize_attemptsdid not carry the index names with it — Postgres does not rename dependent indexes/constraints onALTER TABLE ... RENAME. Both the parent partitioned index (deliveries_pkey) and the default partition index (deliveries_default_pkey) are still stale on every Postgres install.ALTER INDEX ... RENAMEis catalog-only: it takes SHARE UPDATE EXCLUSIVE on the index, no lock on the table, and does not block concurrent DML.pg_constraint.connamefollows automatically and the partition-index attachment is unaffected.Refs #1027 (the "unrelated finding" at the end; this does not address partition management).
🤖 Generated with Claude Code