Skip to content

test: use localhost:1 instead of non-routable IP in migrator test #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexluong merged 1 commit into from
Jan 19, 2026
Merged

test: use localhost:1 instead of non-routable IP in migrator test #649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions internal/migrator/migrator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,21 +70,21 @@ func TestMigrator_CredentialExposure_Integration(t *testing.T) {
},
},
{
name: "ClickHouse - connection timeout scenario",
name: "ClickHouse - connection failure scenario",
opts: MigrationOpts{
CH: MigrationOptsCH{
// Using non-routable IP to simulate timeout
// 192.0.2.0/24 is reserved for documentation (RFC 5737)
Addr: "192.0.2.1:9000",
// Using localhost:1 - port 1 is reserved and will be refused immediately
// This tests credential sanitization without waiting for network timeout
Addr: "localhost:1",
Username: "admin",
Password: "VerySecretPass456$",
Database: "analytics_db",
},
},
shouldFailValidation: false,
checkError: func(t *testing.T, err error) {
// We expect an error due to timeout/unreachable host
require.Error(t, err, "Should fail to connect to unreachable host")
// We expect an error due to connection refused
require.Error(t, err, "Should fail to connect to closed port")

// The error should NOT contain the actual password
assert.NotContains(t, err.Error(), "VerySecretPass456$",
Expand Down