Skip to content

fix(l10n): correct French calendar strings - #77

Merged
ralflang merged 2 commits into
horde:FRAMEWORK_6_0from
pierrefardel:fix/french-calendar-l10n
Jul 24, 2026
Merged

ralflang merged 2 commits into
horde:FRAMEWORK_6_0from
pierrefardel:fix/french-calendar-l10n

Conversation

@pierrefardel

Copy link
Copy Markdown
Contributor

What

Fixes recurring grammatical errors in the French translation (locale/fr/LC_MESSAGES/kronolith.po):

  • de le calendrier → du calendrier (14 occurrences) — de + le must contract to du in French. Affected strings include the calendar title label, owner/summary labels, import/purge/delete messages, the engine-unavailable errors and the "title must not be empty" validation.
  • Nouvel Calendrier / Nouvel calendrier → Nouveau … — calendrier is masculine and starts with a consonant, so the correct form is Nouveau, not Nouvel (which is only used before a vowel/mute-h, e.g. Nouvel événement, left untouched).
  • désincrire → désinscrire — typo.

Why it's visible

The New Calendar string surfaces in two prominent places in the dynamic view: the + button tooltip in the sidebar and the calendar-creation dialog ("Titre de le calendrier" → "Titre du calendrier").

Care was taken not to touch the legitimate de le occurrences where le is a pronoun (e.g. "l'autorisation de le supprimer"). msgfmt -c passes.

Fix recurring grammatical errors in the French translation:
- "de le calendrier" -> "du calendrier" (14 occurrences)
- "Nouvel Calendrier"/"Nouvel calendrier" -> "Nouveau ..." (gender
  agreement: calendrier is masculine and starts with a consonant)
- "désincrire" -> "désinscrire" (typo)

The "New Calendar" title was the most visible one: it surfaces in the
dynamic sidebar (+ button tooltip) and in the calendar creation dialog.
Copilot AI review requested due to automatic review settings July 23, 2026 13:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects visible French localization issues in Kronolith’s calendar UI strings, improving grammatical accuracy and reducing user-facing translation errors.

Changes:

  • Fixes French contractions like de le calendrier → du calendrier across multiple strings.
  • Corrects the masculine form for “New Calendar” translations (Nouvel … → Nouveau …).
  • Fixes a typo (désincrire → désinscrire) in an unsubscribe prompt.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread locale/fr/LC_MESSAGES/kronolith.po Outdated
#: templates/dynamic/sidebar.html.php:33
msgid "New Calendar"
msgstr "Nouvel Calendrier"
msgstr "Nouveau Calendrier"
Match the sentence-case convention of neighbouring French strings
("Nouvel événement", "Nouvelle liste de tâches") — lowercase the
common noun, per review feedback.
@pierrefardel

Copy link
Copy Markdown
Contributor Author

Good catch — fixed in 4a12ff9. Nouveau calendrier now uses sentence case, consistent with Nouvel événement / Nouvelle liste de tâches.

@ralflang

Copy link
Copy Markdown
Member

Thank you!

@ralflang
ralflang merged commit 930a8e3 into horde:FRAMEWORK_6_0 Jul 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants