Repository navigation
perf: skip_stats backport #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ use arrow::array::RecordBatch; | |
| use arrow::compute::{filter_record_batch, is_not_null}; | ||
| use arrow::datatypes::SchemaRef; | ||
| use arrow_arith::aggregate::sum_array_checked; | ||
| use arrow_array::{Int64Array, StructArray}; | ||
| use arrow_array::Int64Array; | ||
| use delta_kernel::actions::{Remove, Sidecar}; | ||
| use delta_kernel::engine::arrow_conversion::TryIntoArrow as _; | ||
| use delta_kernel::engine::arrow_data::ArrowEngineData; | ||
|
|
@@ -270,7 +270,7 @@ impl Snapshot { | |
| log_store: &dyn LogStore, | ||
| predicate: Option<PredicateRef>, | ||
| ) -> SendableRBStream { | ||
| let scan = match self.scan_builder().with_predicate(predicate).build() { | ||
| let scan = match self.scan_builder().with_predicate(predicate).with_skip_stats(true).build() { | ||
| Ok(scan) => scan, | ||
| Err(err) => return Box::pin(once(ready(Err(err)))), | ||
| }; | ||
|
|
@@ -552,7 +552,11 @@ pub(crate) async fn resolve_snapshot( | |
|
|
||
| fn read_adds_size(array: &dyn ProvidesColumnByName) -> usize { | ||
| if let Some(size) = ex::extract_and_cast_opt::<Int64Array>(array, "size") { | ||
| sum_array_checked::<arrow::array::types::Int64Type, _>(size).unwrap().unwrap_or_default() as usize | ||
| sum_array_checked::<arrow::array::types::Int64Type, _>(size) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please find the originating commit and try a fixup on it + force push once this PR gets in, that will make the rebase process simpler |
||
| .ok() | ||
| .flatten() | ||
| .unwrap_or_default() | ||
| .max(0) as usize | ||
| } else { | ||
| 0 | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should byte the bullet and add a config option on the TableConfig so we can change this at runtime. Fine to have the default on false but maybe some queries end up benefitting from stats