Repository navigation
fix(delta): preserve scan metrics during serialization - #23
Closed
radustoenescu wants to merge 2 commits into
Closed
radustoenescu wants to merge 2 commits into
radustoenescu wants to merge 2 commits into
Conversation
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
aditanase
reviewed
Sep 25, 2026
| file_id_column: Option<String>, | ||
| public_file_ids: std::collections::HashMap<String, String>, | ||
| #[serde(default)] | ||
| count_files_scanned: usize, |
Collaborator
There was a problem hiding this comment.
- let's use the already existing mechanics for storing and serializing metrics, in case we want to add/remove others.
- these are the metrics from the old provider (
DeltaScan, metrics=[files_pruned=77, files_scanned=224]). The new provider actually exposes theseDeltaScanExec, metrics=[output_rows=161, elapsed_compute=50.84µs, output_bytes=167.4 MB, output_batches=2, count_files_pruned_by_limit=0, count_files_scanned=3]
radustoenescu
changed the title
adragomir
force-pushed
the
main-1.0-stats
branch
from
September 25, 2026 11:12
6652531 to
984edfe
Compare
radustoenescu
force-pushed
the
fix/explain-analyze-planning-metrics
branch
from
September 25, 2026 12:27
d826b1f to
df9e568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialize each scan's existing metric set with the physical plan instead of maintaining metric-specific fields. This covers classic, next, and metadata-only scans.
Validated with codec round trips and Cobweb's two-worker distributed EXPLAIN ANALYZE regression.