Repository navigation
fix(datafusion): preserve Delta planning count metrics - #24
Merged
radustoenescu merged 2 commits intoSep 30, 2026
Merged
Conversation
Collaborator
Author
|
Prior to merging I will fix the commit title to use our conventions |
aditanase
reviewed
Sep 30, 2026
| fn try_from(exec: &DeltaScanExec) -> Result<Self, Self::Error> { | ||
| let scan_plan_wire = scan_plan_wire(&exec.scan_plan)?; | ||
| let metrics = exec.metrics().ok_or_else(|| { | ||
| DataFusionError::Internal("DeltaScanExec did not expose its metrics".to_string()) |
Collaborator
There was a problem hiding this comment.
do we want to fail on missing metrics? or just return empty
Collaborator
Author
There was a problem hiding this comment.
Yeah, it's probably better not to fail the query due to missing metrics, although that should never happen.
radustoenescu
commented
Sep 30, 2026
Comment on lines
+12
to
+13
| const DFD_AGGREGATION_SCOPE_LABEL: &str = "dfd_aggregation_scope"; | ||
| const COORDINATOR_AGGREGATION_SCOPE: &str = "coordinator"; |
Collaborator
Author
There was a problem hiding this comment.
created_at: planning
radustoenescu
added a commit
that referenced
this pull request
Sep 30, 2026
radustoenescu
pushed a commit
that referenced
this pull request
Oct 22, 2026
…zation (#24, #26) Preserve planning-time count metrics when serializing classic and next Delta scans, with a shared configuration controlling both encoding and decoding. Keep serialization enabled by default; disable it for execution-only worker plans so coordinator-owned counters are not multiplied across tasks. Introduce the final codec implementation directly, without the intermediate created_at=planning label mechanism. Consolidates b9b71be and ebd748a; the resulting repository tree is unchanged from ebd748a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distributed
EXPLAIN ANALYZEloses Delta scan planning counts when physical plans are serialized.This carries named planning counters through the classic and Next scan codecs and marks restored copies as coordinator-owned so distributed execution can report them once.
Tested with the planning-count wire test, codec round trip, and Cobweb classic/Next integration coverage.