Skip to content

Allow namespaces in plugin entrypoints named after the plugin #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kadamwhite wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow namespaces in plugin entrypoints named after the plugin #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
443f213
Relax NamespaceDirectoryNameSniff in plugin entrypoints named after t…
kadamwhite Jun 29, 2026
815305b
Add counterexample failing test case for NamespaceDirectoryNameSniff
kadamwhite Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions HM/Sniffs/Files/NamespaceDirectoryNameSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,13 @@ public function process( File $phpcsFile, $stackPtr ) {
return;
}

if ( in_array( basename( dirname( $directory ) ), [ 'plugins', 'client-mu-plugins', 'mu-plugins' ], true ) ) {
if ( pathinfo( $filename, PATHINFO_FILENAME ) === basename( $directory ) ) {
// Allow plugin entrypoints named `plugin-name/plugin-name.php` instead of `plugin.php`.
return;
}
}

if ( ! preg_match( '#(?:.*)(?:/inc|/tests)(/.*)?#', $directory, $matches ) ) {
$error = 'Namespaced classes and functions should live inside an inc directory.';
$phpcsFile->addError( $error, $stackPtr, 'NoIncDirectory' );
Expand Down
3 changes: 3 additions & 0 deletions HM/Tests/Files/NamespaceDirectoryNameUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ public function getErrorList() {
// Single-file mu-plugins are exempt from the directory structure rules.
'mu-plugin.php',
'client-mu-plugin.php',
// Plugin entrypoints should also allow namespace declarations.
'mypluginname.php',
'plugin.php',
];
if ( in_array( $file, $pass, true ) ) {
return [];
Expand Down
3 changes: 3 additions & 0 deletions HM/Tests/Files/NamespaceDirectoryNameUnitTest/plugins/mypluginname/improperly-named.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<?php

namespace HM\Coding\Standards\My_Plugin_Name;
3 changes: 3 additions & 0 deletions HM/Tests/Files/NamespaceDirectoryNameUnitTest/plugins/mypluginname/mypluginname.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<?php

namespace HM\Coding\Standards\My_Plugin_Name;
3 changes: 3 additions & 0 deletions HM/Tests/Files/NamespaceDirectoryNameUnitTest/plugins/mypluginname/plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<?php

namespace HM\Coding\Standards\My_Plugin_Name;