Declare jinja2, which training needs to render chat templates - #52
Merged
Merged
Conversation
CI on main failed test_sample_length with "apply_chat_template requires jinja2 to be installed". transformers renders chat templates with jinja2 but does not depend on it, so a clean install could not build a single training sample. Macs usually had it by accident, through mlx-lm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vhZ7i2tU8r4RQ1VBfqfcg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
jinja2>=3.1.0to the dependencies inpyproject.tomlandrequirements.txt.Why
The
testsworkflow onmainfails one test,tests/test_sample_length.py::test_seed_samples_fit_the_configured_window, with:transformersrenders chat templates with jinja2 but doesn't declare it as a dependency. So a cleanpip install symbio-clicould not build a single training sample. On Macs it was usually installed by accident through mlx-lm, which is why nobody hit it.Testing
Ran the full suite in a fresh virtualenv (
pip install -e ".[dev]") on top of currentmain: 2371 passed, 240 skipped, 0 failed.🤖 Generated by claude code