Migrate to jsr specifiers - #109
Conversation
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
|
|
It looks like the new changes break the build. cc @mcandeia |
Greptile SummaryThis PR migrates the Deno logging integration from pinned deno.land standard-library URLs to JSR specifiers and adapts the handler to the newer logging API.
Confidence Score: 4/5The PR appears safe to merge after addressing the non-blocking formatting and dependency-pinning concerns. The migration has no established current runtime failure, but it violates the repository's quote convention and makes std/log resolution depend on an unconstrained registry release. Files Needing Attention: packages/deno/mod.ts
|
| Filename | Overview |
|---|---|
| packages/deno/mod.ts | Migrates standard-library logging imports and APIs to JSR, but introduces repository-formatting violations and leaves the new dependency unconstrained. |
Reviews (1): Last reviewed commit: "Merge branch 'main' into use-jsr-update-..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -1,73 +1,70 @@ | |||
| // Derived from https://github.com/denoland/deno_std/blob/main/log/handlers.ts | |||
| import * as log from 'https://deno.land/std@0.203.0/log/mod.ts'; | |||
| import * as log from "jsr:@std/log"; | |||
There was a problem hiding this comment.
The migration changes string literals throughout this module to double quotes, while the repository guidance requires single quotes. This creates avoidable formatting churn and leaves the file inconsistent with the prescribed style.
Context Used: AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| import * as log from "jsr:@std/log"; | ||
|
|
||
| import type { LogRecord } from 'https://deno.land/std@0.203.0/log/logger.ts'; | ||
| import { | ||
| LevelName, | ||
| LogLevels, | ||
| } from 'https://deno.land/std@0.203.0/log/levels.ts'; | ||
| import { LevelName, LogLevels } from "jsr:@std/log/levels"; | ||
| import type { LogRecord } from "jsr:@std/log/logger"; |
There was a problem hiding this comment.
These imports replace the pinned std@0.203.0 dependency with an unconstrained jsr:@std/log release, while the repository has no Deno lockfile or import map fixing its resolution. Fresh builds can therefore resolve a different API without any repository change, undermining reproducibility and eventually breaking the specific handler exports used below.
2 participants
No description provided.