feat(fftls,ffresty,ffdns,ffnet) Networking Metrics and IP/Server Configs#218
Merged
EnriqueL8 merged 11 commits intoJun 24, 2026
Merged
Conversation
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
…work as expected - CA bundles make metrics for all certs, leaf only the leaf w/ a key makes a metric Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Contributor
|
Approved |
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
onelapahead
changed the title
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
EnriqueL8
reviewed
Jun 19, 2026
EnriqueL8
left a comment
EnriqueL8
left a comment
Contributor
There was a problem hiding this comment.
Thanks @onelapahead ! A few comments
onelapahead
changed the title
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
onelapahead
changed the title
onelapahead
commented
Jun 19, 2026
onelapahead
changed the title
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
EnriqueL8
reviewed
Jun 22, 2026
Comment on lines
+32
to
+49
| var testSSRDenylist = []string{ | ||
| "0.0.0.0/8", // unspecified / "this host" (RFC 1122) | ||
| "127.0.0.0/8", // IPv4 loopback | ||
| "169.254.0.0/16", // IPv4 link-local, incl. cloud metadata 169.254.169.254 | ||
| "10.0.0.0/8", // IPv4 private RFC1918 | ||
| "172.16.0.0/12", // IPv4 private RFC1918 | ||
| "192.168.0.0/16", // IPv4 private RFC1918 | ||
| "100.64.0.0/10", // IPv4 CGNAT | ||
| "224.0.0.0/4", // IPv4 multicast | ||
| "240.0.0.0/4", // IPv4 reserved (incl. 255.255.255.255 broadcast) | ||
| "fc00::/7", // IPv6 ULA | ||
| "fe00::/8", // IPv6 private RFC4193 | ||
| "ff00::/8", // IPv6 reserved | ||
| "::ffff:127.0.0.1/128", // IPv4-mapped IPv6 loopback | ||
| "::1/128", // IPv6 loopback | ||
| "::/0", // IPv6 unspecified | ||
| "::/128", // IPv6 unspecified | ||
| } |
Contributor
There was a problem hiding this comment.
Really like this doc via UT approach 👍
peterbroadhurst
approved these changes
Jun 22, 2026
peterbroadhurst
left a comment
peterbroadhurst
left a comment
Contributor
There was a problem hiding this comment.
Looks great - thanks for working through the iterations.
EnriqueL8
reviewed
Jun 23, 2026
EnriqueL8
left a comment
EnriqueL8
left a comment
Contributor
There was a problem hiding this comment.
Looks good, some copyright updates
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
EnriqueL8
approved these changes
Jun 24, 2026
EnriqueL8
left a comment
EnriqueL8
left a comment
Contributor
There was a problem hiding this comment.
Thanks you @onelapahead !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fftls
Like
ffrestyand other pacakges - a static registration of a metrics registry makes a shared metrics manager subsystem and a single metric withissuer,subject, andtypelabels. Where thefloat64value of the gauge is the Unix timestamp of the expiry date (common pattern in Prom metrics like in FF DX metrics and Besu/Erigon timeSinceLastBlock).ffdns
A new config and resolver builder for customizing DNS timeouts and (name)servers for lookups. With metrics if enabled (though I don't think most users want DNS metrics always on as its expensive).
ffnet
A custom
Dialerwith a configurable CIDR denylist for IP ranges to reject. Defaults to empty. Users can configure it to default to specific IANA IP ranges they may need to deny based on their use case (internal service-to-service client can be more permissive than a user-configurable webhooks client needing full SSRF protection).ffresty
Builds on
ffdnsandffnetto embed their configs respectively like it doesfftls.Note that previously we never prescribed netgo - letting the compile time of the runtime determine what DNS implementation is used. When
ffdns(timeout, servers, or metrics) is used, netgo must be used and is therefore specified.