Harden smali folder name validation during build to prevent path traversal - #4182
Draft
iBotPeaches with Copilot wants to merge 2 commits into
Draft
Harden smali folder name validation during build to prevent path traversal#4182iBotPeaches with Copilot wants to merge 2 commits into
iBotPeaches with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Harden smali folder during build process
Harden smali folder name validation during build to prevent path traversal
Jul 22, 2026
iBotPeaches
force-pushed
the
copilot/harden-smali-folder-during-build
branch
from
July 24, 2026 10:42
edf683e to
e9697b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directories named
smali_<suffix>in decoded projects are converted to dex output paths by replacing@with the platform path separator. A malicious directory name likesmali_..@..@..@outsideproduces../../../outside.dex, enabling arbitrary file writes outside the build output directory.Changes
ApkBuilder.java: After computingfileNamefrom asmali_directory name, validate the derived path using the existingBrutIO.sanitizePath(outDir, fileName). ThrowsAndrolibExceptionif the resolved path escapesoutDir.SmaliDirectoryTraversalTest.java(new): Verifies that building a project containing asmali_..@..@..@outsidedirectory throwsAndrolibExceptionrather than writing files outside the project.