Skip to content

fix: treat digit-only strings of 9+ chars as invalid (#2955) #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prasanthmaran wants to merge 1 commit into
base: dev
Choose a base branch
from
+16 −1
Open

fix: treat digit-only strings of 9+ chars as invalid (#2955) #3124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/constant.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ export const FORMAT_DEFAULT = 'YYYY-MM-DDTHH:mm:ssZ'
export const INVALID_DATE_STRING = 'Invalid Date'

// regex
export const REGEX_PARSE = /^(\d{4})[-/]?(\d{1,2})?[-/]?(\d{0,2})[Tt\s]*(\d{1,2})?:?(\d{1,2})?:?(\d{1,2})?[.:]?(\d+)?$/
export const REGEX_PARSE = /^(?!\d{9,}$)(\d{4})[-/]?(\d{1,2})?[-/]?(\d{0,2})[Tt\s]*(\d{1,2})?:?(\d{1,2})?:?(\d{1,2})?[.:]?(\d+)?$/
export const REGEX_FORMAT = /\[([^\]]+)]|YYYY|YY|M{1,4}|D{1,2}|d{1,4}|H{1,2}|h{1,2}|a|A|m{1,2}|s{1,2}|Z{1,2}|SSS/g
15 changes: 15 additions & 0 deletions test/parse.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,3 +213,18 @@ describe('REGEX_PARSE', () => {
expect(d).toBe(null)
})
})

describe('Timestamp string', () => {
// #2955
it('timestamp passed as string is invalid', () => {
expect(dayjs('1762232987879').isValid()).toBe(false)
expect(dayjs('1581314281').isValid()).toBe(false)
expect(dayjs('123456789').isValid()).toBe(false)
})
it('digit-only date formats still parse', () => {
expect(dayjs('2018').year()).toBe(2018)
expect(dayjs('201805').format('YYYY-MM')).toBe('2018-05')
expect(dayjs('20180517').format('YYYY-MM-DD')).toBe('2018-05-17')
expect(dayjs('20210102T012345').isValid()).toBe(true)
})
})