[Don't merge] Add empty flex transfer - #317
Draft
leonardehrenfried wants to merge 31 commits into
Draft
Conversation
Leave the stop headsign unset when a SIRI-ET call has no destination display and the trip has no headsign, instead of storing an empty NonLocalizedString. This removes the empty-string 'no data' sentinel and the per-call allocation, and aligns the added/extra-call trip path with the scheduled GTFS path (which already yields a null headsign here). Follow-up from review of opentripplanner#7783.
…Snapshot` interfaces with lifecycle support (unused for now)
…ot` interfaces throughout the codebase
…own the single-writer scheduler
…d remove `clearForBuffer` method
…/test-dependencies Update Test dependencies to v6.1.2
…rkTest-more-robust Make TransactionFrameworkTest#testPeriodicCommits more robust.
…andler Next stop is to refactor this class and extract the adapter logic
…andler Next stop is to refactor this class and extract the adapter logic
…nsitEditorService` per update task # Conflicts: # application/src/main/java/org/opentripplanner/updater/trip/gtfs/GtfsRealTimeTripUpdateAdapter.java (cherry picked from commit 709a4b3)
…ush` to `TimetableSnapshotLifecycle` and transaction framework (cherry picked from commit fd2e626)
…bleSnapshot` provider from `TransitModule` (cherry picked from commit e14373d)
…pMatcher` per update task (cherry picked from commit 7146616)
(cherry picked from commit c4531e5)
…bleRepository (cherry picked from commit a2194a1)
(cherry picked from commit 31d4841)
Co-authored-by: Thomas Gran <t2gran@gmail.com>
…-framework Snapshot framework
…/google.dagger.version fix(deps): update google.dagger.version to v2.60.1
…mpty-string Do not use empty string as headsign sentinel in StopTimesMapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one adds an empty transfer leg if you transfer from bus to flex at the same stop.
Make sure you enabled
ExtraTransferLegOnSameStop, which apparently is already switched on: https://github.com/ibi-group/open-source-configurations/blob/main/septa/otp-config.json#L3