Added filterUndefined params to array rule#354
Open
vrag86 wants to merge 1 commit into
Open
Conversation
icebob-ai
requested changes
Apr 1, 2026
Collaborator
icebob-ai
left a comment
There was a problem hiding this comment.
Thanks for the PR, @vrag86!
The idea of filtering values from arrays is useful, but there are a few issues to address:
Missing pieces
- No tests — need at least: filterUndefined removes undefined, doesn't remove null/falsy, works with items validation, disabled by default
- No TypeScript type updates —
RuleArrayinindex.d.tsneeds afilterUndefined?: booleanproperty - No README documentation for the new option
Design concern
A more universal approach would be better here. Instead of only filtering undefined, consider a more general option like filter that could handle multiple cases:
- Filter
undefinedvalues - Filter
nullvalues - Filter both
nullandundefined(nullish) - Or even a custom filter function
Something like filter: "undefined" | "null" | "nullish" or filter: (value) => boolean would be more flexible and cover more use cases.
Please consider reworking this with a broader design, adding tests, TypeScript types, and documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add filterUndefined params to array rule. It need when create custom items validator and skip not validated items