Skip to content

MessageBuilder: fix typo #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stokito wants to merge 3 commits into
base: master
Choose a base branch
from
Open

MessageBuilder: fix typo #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a9febd
MessageBuilder: fix typo
stokito Oct 19, 2025
8802d6b
MessageBuilder: put semicolon in the same line
stokito Feb 28, 2026
5c2a35f
JavaDoc: fix old XEP links http://www.xmpp.org/extensions/jep-XXXX.ht…
stokito Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions smack-core/src/main/java/org/jivesoftware/smack/packet/MessageBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ private void copyFromMessage(Message message) {

@Override
protected void addStanzaSpecificAttributes(ToStringUtil.Builder builder) {
builder.addValue("type", type)
;
builder.addValue("type", type);
Comment thread
stokito marked this conversation as resolved.
}

public MessageBuilder ofType(Message.Type type) {
Expand Down Expand Up @@ -138,7 +137,7 @@ public MessageBuilder addBody(String language, String body) {

for (Body currentBody : getExtensions(Body.class)) {
if (StringUtils.nullSafeCharSequenceEquals(language, currentBody.getLanguage())) {
throw new IllegalArgumentException("Bodyt with the language " + language + " already exists");
throw new IllegalArgumentException("Body with the language " + language + " already exists");
}
}

Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/address/MultipleRecipientManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

/**
* A MultipleRecipientManager allows to send packets to multiple recipients by making use of
* <a href="http://www.xmpp.org/extensions/jep-0033.html">XEP-33: Extended Stanza Addressing</a>.
* <a href="https://xmpp.org/extensions/xep-0033.html">XEP-33: Extended Stanza Addressing</a>.
* It also allows to send replies to packets that were sent to multiple recipients.
*
* @author Gaston Dombiak
Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/caps/EntityCapsManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
* }</pre>
*
* @author Florian Schmaus
* @see <a href="http://www.xmpp.org/extensions/xep-0115.html">XEP-0115: Entity Capabilities</a>
* @see <a href="https://xmpp.org/extensions/xep-0115.html">XEP-0115: Entity Capabilities</a>
*/
public final class EntityCapsManager extends Manager {

Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/chatstates/ChatState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

/**
* Represents the current state of a users interaction with another user. Implemented according to
* <a href="http://www.xmpp.org/extensions/xep-0085.html">XEP-0085</a>.
* <a href="https://xmpp.org/extensions/xep-0085.html">XEP-0085</a>.
*
* @author Alexander Wenckus
*/
Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/chatstates/ChatStateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
/**
* Handles chat state for all chats on a particular XMPPConnection. This class manages both the
* stanza extensions and the disco response necessary for compliance with
* <a href="http://www.xmpp.org/extensions/xep-0085.html">XEP-0085</a>.
* <a href="https://xmpp.org/extensions/xep-0085.html">XEP-0085</a>.
*
* NOTE: {@link org.jivesoftware.smackx.chatstates.ChatStateManager#getInstance(org.jivesoftware.smack.XMPPConnection)}
* needs to be called in order for the listeners to be registered appropriately with the connection.
Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/chatstates/package-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*/

/**
* Classes for Chat States (<a href="http://www.xmpp.org/extensions/xep-0085.html">XEP-0085</a>).
* Classes for Chat States (<a href="https://xmpp.org/extensions/xep-0085.html">XEP-0085</a>).
*/
package org.jivesoftware.smackx.chatstates;
4 changes: 2 additions & 2 deletions ...extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FileTransferNegotiator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,9 @@ public static String getNextStreamID() {
* If they accept, the stanza will contain the other user's chosen stream
* type to send the file across. The two choices this implementation
* provides to the other user for file transfer are <a
* href="http://www.xmpp.org/extensions/jep-0065.html">SOCKS5 Bytestreams</a>,
* href="https://xmpp.org/extensions/xep-0065.html">SOCKS5 Bytestreams</a>,
* which is the preferred method of transfer, and <a
* href="http://www.xmpp.org/extensions/jep-0047.html">In-Band Bytestreams</a>,
* href="https://xmpp.org/extensions/xep-0047.html">In-Band Bytestreams</a>,
* which is the fallback mechanism.
* </p>
* <p>
Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/geoloc/packet/GeoLocation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
/**
* A GeoLocation Extension packet, which is used by the XMPP clients to exchange their respective geographic locations.
*
* @see <a href="http://www.xmpp.org/extensions/xep-0080.html">XEP-0080</a>
* @see <a href="https://xmpp.org/extensions/xep-0080.html">XEP-0080</a>
* @author Ishan Khanna
*/
public final class GeoLocation implements Serializable, ExtensionElement, FormFieldChildElement {
Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/iqprivate/PrivateDataManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
* a {@link DefaultPrivateData} instance will be returned.<p>
*
* Warning: this is an non-standard protocol documented by
* <a href="http://www.xmpp.org/extensions/jep-0049.html">XEP-49</a>. Because this is a
* <a href="https://xmpp.org/extensions/xep-0049.html">XEP-49</a>. Because this is a
* non-standard protocol, it is subject to change.
*
* @author Matt Tucker
Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ public class MucCreateConfigFormHandle {
* @throws XMPPErrorException if there was an XMPP error returned.
* @throws NotConnectedException if the XMPP connection is not connected.
* @throws InterruptedException if the calling thread was interrupted.
* @see <a href="http://www.xmpp.org/extensions/xep-0045.html#createroom-instant">XEP-45 § 10.1.2 Creating an
* @see <a href="https://xmpp.org/extensions/xep-0045.html#createroom-instant">XEP-45 § 10.1.2 Creating an
* Instant Room</a>
*/
public void makeInstant() throws NoResponseException, XMPPErrorException, NotConnectedException,
Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/ping/PingManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
* </p>
*
* @author Florian Schmaus
* @see <a href="http://www.xmpp.org/extensions/xep-0199.html">XEP-0199:XMPP Ping</a>
* @see <a href="https://xmpp.org/extensions/xep-0199.html">XEP-0199:XMPP Ping</a>
*/
public final class PingManager extends Manager {
private static final Logger LOGGER = Logger.getLogger(PingManager.class.getName());
Expand Down
4 changes: 2 additions & 2 deletions smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/AffiliationsExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@

/**
* Represents the <b>affiliations</b> element of the reply to a request for affiliations.
* It is defined in the specification in section <a href="http://xmpp.org/extensions/xep-0060.html#entity-affiliations">5.7 Retrieve Affiliations</a> and
* <a href="http://www.xmpp.org/extensions/xep-0060.html#owner-affiliations">8.9 Manage Affiliations</a>.
* It is defined in the specification in section <a href="https://xmpp.org/extensions/xep-0060.html#entity-affiliations">5.7 Retrieve Affiliations</a> and
* <a href="https://xmpp.org/extensions/xep-0060.html#owner-affiliations">8.9 Manage Affiliations</a>.
*
* @author Robin Collier
*/
Expand Down
6 changes: 3 additions & 3 deletions smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/Node.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public List<Subscription> getSubscriptionsAsOwner() throws NoResponseException,
* @throws XMPPErrorException if there was an XMPP error returned.
* @throws NotConnectedException if the XMPP connection is not connected.
* @throws InterruptedException if the calling thread was interrupted.
* @see <a href="http://www.xmpp.org/extensions/xep-0060.html#owner-subscriptions-retrieve">XEP-60 § 8.8.1 -
* @see <a href="https://xmpp.org/extensions/xep-0060.html#owner-subscriptions-retrieve">XEP-60 § 8.8.1 -
* Retrieve Subscriptions List</a>
* @since 4.1
*/
Expand Down Expand Up @@ -321,7 +321,7 @@ public List<Affiliation> getAffiliationsAsOwner()
* @throws XMPPErrorException if there was an XMPP error returned.
* @throws NotConnectedException if the XMPP connection is not connected.
* @throws InterruptedException if the calling thread was interrupted.
* @see <a href="http://www.xmpp.org/extensions/xep-0060.html#owner-affiliations-retrieve">XEP-60 § 8.9.1 Retrieve Affiliations List</a>
* @see <a href="https://xmpp.org/extensions/xep-0060.html#owner-affiliations-retrieve">XEP-60 § 8.9.1 Retrieve Affiliations List</a>
* @since 4.2
*/
public List<Affiliation> getAffiliationsAsOwner(List<XmlElement> additionalExtensions, Collection<XmlElement> returnedExtensions)
Expand Down Expand Up @@ -362,7 +362,7 @@ private List<Affiliation> getAffiliations(AffiliationNamespace affiliationsNames
* @throws XMPPErrorException if there was an XMPP error returned.
* @throws NotConnectedException if the XMPP connection is not connected.
* @throws InterruptedException if the calling thread was interrupted.
* @see <a href="http://www.xmpp.org/extensions/xep-0060.html#owner-affiliations-modify">XEP-60 § 8.9.2 Modify Affiliation</a>
* @see <a href="https://xmpp.org/extensions/xep-0060.html#owner-affiliations-modify">XEP-60 § 8.9.2 Modify Affiliation</a>
* @since 4.2
*/
public PubSub modifyAffiliationAsOwner(List<Affiliation> affiliations) throws NoResponseException,
Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/PubSubFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* The features a PubSub service may provides. Some are optional or recommended, while others are required.
*
* @author Florian Schmaus
* @see <a href="http://www.xmpp.org/extensions/xep-0060.html#features">XEP-60 § 10</a>
* @see <a href="https://xmpp.org/extensions/xep-0060.html#features">XEP-60 § 10</a>
*
*/
public enum PubSubFeature implements CharSequence {
Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/time/packet/Time.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* times. Clients that wish to fully support the entity time protocol should register
* a PacketListener for incoming time requests that then respond with the local time.
*
* @see <a href="http://www.xmpp.org/extensions/xep-0202.html">XEP-202</a>
* @see <a href="https://xmpp.org/extensions/xep-0202.html">XEP-202</a>
* @author Florian Schmaus
*/
public class Time extends IQ implements TimeView {
Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/packet/VCard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
* <a href="http://www.jivesoftware.org/smack/" target="_blank">SMACK jabber library</a>.<p>
*
* You should refer to the
* <a href="http://www.xmpp.org/extensions/jep-0054.html" target="_blank">XEP-54 documentation</a>.<p>
* <a href="https://xmpp.org/extensions/xep-0054.html" target="_blank">XEP-54 documentation</a>.<p>
*
* Please note that this class is incomplete but it does provide the most commonly found
* information in vCards. Also remember that VCard transfer is not a standard, and the protocol
Expand Down
10 changes: 5 additions & 5 deletions ...ensions/src/main/java/org/jivesoftware/smackx/xdatavalidation/packet/ValidateElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@ private ValidateElement(String datatype) {
* following conditions:
* <ul>
* <li>Start with "xs:", and be one of the "built-in" datatypes defined in XML Schema Part 2 <a
* href="http://www.xmpp.org/extensions/xep-0122.html#nt-idp1476016">[2]</a></li>
* href="https://xmpp.org/extensions/xep-0122.html#nt-idp1476016">[2]</a></li>
* <li>Start with a prefix registered with the XMPP Registrar <a
* href="http://www.xmpp.org/extensions/xep-0122.html#nt-idp1478544">[3]</a></li>
* href="https://xmpp.org/extensions/xep-0122.html#nt-idp1478544">[3]</a></li>
* <li>Start with "x:", and specify a user-defined datatype <a
* href="http://www.xmpp.org/extensions/xep-0122.html#nt-idp1477360">[4]</a></li>
* href="https://xmpp.org/extensions/xep-0122.html#nt-idp1477360">[4]</a></li>
* </ul>
*
* @return the datatype
Expand Down Expand Up @@ -327,9 +327,9 @@ public void validate(FormField formField) {

/**
* Indicates that the value should be restricted to a regular expression. The regular expression must be that
* defined for <a href="http://www.xmpp.org/extensions/xep-0122.html#nt-idp1501344"> POSIX extended regular
* defined for <a href="https://xmpp.org/extensions/xep-0122.html#nt-idp1501344"> POSIX extended regular
* expressions </a> including support for <a
* href="http://www.xmpp.org/extensions/xep-0122.html#nt-idp1502496">Unicode</a>.
* href="https://xmpp.org/extensions/xep-0122.html#nt-idp1502496">Unicode</a>.
*
* @see ValidateElement
*/
Expand Down
2 changes: 1 addition & 1 deletion smack-extensions/src/main/java/org/jivesoftware/smackx/xhtmlim/packet/XHTMLExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
* extension is only a subset of XHTML 1.0.
* <p>
* The following link summarizes the requirements of XHTML IM:
* <a href="http://www.xmpp.org/extensions/xep-0071.html">XEP-0071: XHTML-IM</a>.
* <a href="https://xmpp.org/extensions/xep-0071.html">XEP-0071: XHTML-IM</a>.
* </p>
*
* @author Gaston Dombiak
Expand Down
4 changes: 2 additions & 2 deletions smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/Jingle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
* An Jingle sub-packet, which is used by XMPP clients to exchange info like
* descriptions and transports. The following link summarizes the
* requirements of Jingle IM: <a
* href="http://www.xmpp.org/extensions/jep-0166.html">Valid tags</a>.
* href="https://xmpp.org/extensions/xep-0166.html">Valid tags</a>.
*
* Warning: this is an non-standard protocol documented by <a
* href="http://www.xmpp.org/extensions/jep-0166.html">XEP-166</a>. Because this is
* href="https://xmpp.org/extensions/xep-0166.html">XEP-166</a>. Because this is
* a non-standard protocol, it is subject to change.
*
* @author Alvaro Saurin
Expand Down
2 changes: 1 addition & 1 deletion smack-legacy/src/main/java/org/jivesoftware/smackx/xroster/package-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
* <li>Receive roster entries</li>
* </ul>
* <p>
* <strong>XEP related:</strong> <a href="http://www.xmpp.org/extensions/xep-0093.html">XEP-93</a>
* <strong>XEP related:</strong> <a href="https://xmpp.org/extensions/xep-0093.html">XEP-93</a>
* </p>
* <h2 id="send-a-entire-roster">Send a entire roster</h2>
* <p>
Expand Down