Add benchmark measurements - #121
Merged
Merged
Conversation
pdobacz
reviewed
May 13, 2022
added 9 commits
May 19, 2022 22:26
pdobacz
approved these changes
Jun 3, 2022
| # alternative just-in-time compilation (could run 50% slower) | ||
| # geth_benchmark = ['go', 'run', './instrumentation_measurement/geth_benchmark/tests/imapp_benchmark/imapp_bench.go'] | ||
|
|
||
| args = ['--sampleSize', '{}'.format(sampleSize)] |
Contributor
There was a problem hiding this comment.
is the sampleSize argument relevant at all for benchmark mode (x3)?
Contributor
Author
There was a problem hiding this comment.
It still makes sense in that the sample size means the number of benchmark runs. The default is 1, but we can run benchmark multiple times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the following PRs explaining changes required in submodules: