CROSSLINK-264 retry-action by adamdickmeiss · Pull Request #622 · indexdata/crosslink

adamdickmeiss · 2026-05-29T11:58:12Z

https://index-data.atlassian.net/browse/CROSSLINK-264

Copilot

Pull request overview

This PR adds retry-related entries to the returnables patron-request state model for CROSSLINK-264, introducing a requester-side retry event and supplier-side retry action.

Changes:

Adds accept-retry event on requester SENT, transitioning to NEW.
Adds ask-retry action on supplier VALIDATED, transitioning to NEW.
Keeps generated runtime JSON in sync with misc/returnables.yaml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`misc/returnables.yaml`	Adds retry event/action declarations to the source state model.
`broker/patron_request/service/statemodels/returnables.json`	Updates the generated embedded runtime state model with the same retry declarations.

(yes, tests do not pass)

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

…ry-action

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.

jakub-id · 2026-06-19T13:13:55Z

broker/patron_request/service/action.go — finalizeActionExecution, retry PR auto-action error handling

When auto-actions fail on the new (retry) PR, there is no trace of this failure on the original PR. I think we should ensure the original PR is also marked as needing attention (NeedsAttention = true) in this case — similar to what we do when auto-actions fail on the original PR itself (where markActionChainFailure is called explicitly). As it stands, the original PR ends up in RETRY_ACCEPTED with no indication that something went wrong with the follow-up.

jakub-id · 2026-06-19T13:14:36Z

misc/returnables.yaml / broker/patron_request/service/statemodels/returnables.json — supplier WILL_SUPPLY state

ask-retry should also be available from WILL_SUPPLY on the supplier side, not only from VALIDATED. A supplier might discover that the item is not found as cited after they have already indicated they will supply (e.g. during physical retrieval). Without this, a lender in WILL_SUPPLY state has no way to request a retry.

Copilot

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated no new comments.

adamdickmeiss · 2026-06-19T16:32:58Z

broker/patron_request/service/action.go — finalizeActionExecution, retry PR auto-action error handling

When auto-actions fail on the new (retry) PR, there is no trace of this failure on the original PR. I think we should ensure the original PR is also marked as needing attention (NeedsAttention = true) in this case — similar to what we do when auto-actions fail on the original PR itself (where markActionChainFailure is called explicitly). As it stands, the original PR ends up in RETRY_ACCEPTED with no indication that something went wrong with the follow-up.

Done

adamdickmeiss · 2026-06-19T16:33:30Z

misc/returnables.yaml / broker/patron_request/service/statemodels/returnables.json — supplier WILL_SUPPLY state

ask-retry should also be available from WILL_SUPPLY on the supplier side, not only from VALIDATED. A supplier might discover that the item is not found as cited after they have already indicated they will supply (e.g. during physical retrieval). Without this, a lender in WILL_SUPPLY state has no way to request a retry.

Done

jakub-id

@adamdickmeiss There's a conceptual problem here: the NotFoundAsCited aka Transfer must restart locating suppliers because the new Bib ID can result in different holdings. This is a different use case than the regular retry which is sent to the same supplier and the rota is unchanged. Since we operate on the same transaction, I think we should call locate-suppliers again but change it so that it skips all existing suppliers first, does the new lookup and appends new suppliers to the list. Then select the first new supplier. It also means the fix for supplierUniqueId overriding the localId is not be needed -- we should only use the updated ID when the reason retry is NotFoundAsCited or Transfer.

jakub-id · 2026-06-19T21:22:42Z

+        prevReqId:
+          type: string
+          description: ID of the previous patron request in the sequence
+        retryBibInfo:


this should use a proper Go type in the API model via the overlay and avoid going through the map

CROSSLINK-264 ask-retry action

febe0f2

Copilot AI review requested due to automatic review settings May 29, 2026 11:58

adamdickmeiss requested review from JanisSaldabols and jakub-id as code owners May 29, 2026 11:58

adamdickmeiss marked this pull request as draft May 29, 2026 11:58

Copilot started reviewing on behalf of adamdickmeiss May 29, 2026 11:58 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

Comment thread misc/returnables.yaml Outdated

Comment thread misc/returnables.yaml Outdated

adamdickmeiss added 3 commits May 29, 2026 16:37

RETRY_REQUESTED state

ac9170a

(yes, tests do not pass)

Merge branch 'main' into CROSSLINK-264-ask-retry-action

d2f057b

Update state model for retry

67708e4

Copilot AI review requested due to automatic review settings June 1, 2026 12:31

Copilot started reviewing on behalf of adamdickmeiss June 1, 2026 12:32 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Potential fix for pull request finding

fa8eb8c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 1, 2026 12:38

Copilot started reviewing on behalf of adamdickmeiss June 1, 2026 12:38 View session

adamdickmeiss and others added 2 commits June 1, 2026 14:38

Potential fix for pull request finding

920a937

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

update returnables.json

ddb2333

Copilot AI reviewed Jun 1, 2026

View reviewed changes

adamdickmeiss added 6 commits June 2, 2026 10:57

Implement ask-retry

4f1c545

Create retry-conditonal event

e7bf570

illmock: RETRY:NOTFOUNDASCITED

524a26a

reject-retry

9529072

illmock: sets DeliveryInfo.ItemId on RETRY:NOTFOUNDASCITED

0b7be58

acceptRetry begin

d1f9912

Copilot AI review requested due to automatic review settings June 2, 2026 13:02

Copilot started reviewing on behalf of adamdickmeiss June 2, 2026 13:03 View session

Copilot AI reviewed Jun 2, 2026

View reviewed changes

Comment thread broker/patron_request/service/statemodel_capabilities.go

Comment thread broker/patron_request/service/message-handler.go

Comment thread misc/returnables.yaml Outdated

adamdickmeiss added 2 commits June 2, 2026 17:09

Add {next,prev}_req_id

95586a0

Merge remote-tracking branch 'origin/main' into CROSSLINK-264-ask-ret…

cb56c77

…ry-action

Copilot started reviewing on behalf of adamdickmeiss June 19, 2026 10:59 View session

check err

5fb2369

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread broker/patron_request/service/action.go Outdated

one transaction

ee67aa8

Copilot AI review requested due to automatic review settings June 19, 2026 11:18

Copilot started reviewing on behalf of adamdickmeiss June 19, 2026 11:18 View session

slightly simpler

4063416

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread broker/patron_request/service/action.go Outdated

adamdickmeiss added 2 commits June 19, 2026 13:41

Wait longer for Postgres containers to start

2906253

IllRequest headers align

22d8fcd

Copilot AI review requested due to automatic review settings June 19, 2026 11:44

Copilot started reviewing on behalf of adamdickmeiss June 19, 2026 11:44 View session

rename

a8fd1f6

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread broker/patron_request/service/action.go Outdated

Comment thread broker/patron_request/service/message-handler.go Outdated

CP

7a46c1c

Copilot AI review requested due to automatic review settings June 19, 2026 11:55

Copilot started reviewing on behalf of adamdickmeiss June 19, 2026 11:55 View session

adamdickmeiss requested a review from jakub-id June 19, 2026 12:00

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread broker/test/patron_request/api/api-handler_test.go Outdated

Comment thread broker/test/patron_request/api/api-handler_test.go Outdated

Comment thread broker/test/patron_request/api/api-handler_test.go Outdated

CP

7d40955

ask-retry also in WILL_SUPPLY state

0fbc59f

Copilot AI review requested due to automatic review settings June 19, 2026 16:01

Copilot started reviewing on behalf of adamdickmeiss June 19, 2026 16:02 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Failure on original PR when actions fail on retry PR

c959dc0

jakub-id reviewed Jun 20, 2026

View reviewed changes

Conversation

adamdickmeiss commented May 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakub-id commented Jun 19, 2026

Uh oh!

jakub-id commented Jun 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

adamdickmeiss commented Jun 19, 2026

Uh oh!

adamdickmeiss commented Jun 19, 2026

Uh oh!

jakub-id left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakub-id Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

jakub-id left a comment •

edited

Loading