wake_on_lan, lx200_10micron: replace raw socket WoL with wakeonlan#2414
Merged
Conversation
…nlan)
The raw UDP broadcast implementation (port 9, 255.255.255.255) did not
reliably wake target hosts. Replace with system("wakeonlan <mac>") which
delegates to the wakeonlan tool and works correctly.
If wakeonlan is not installed (exit code 127), a clear error is logged
asking the user to install it. The tool is available on Linux distributions
and macOS (via Homebrew).
wake_on_lan: also refactors ISNewSwitch() with a handleSend lambda to
eliminate code duplication across the 4 device slots, and removes the
now-unused socket headers.
lx200_10micron: removes now-unused socket headers (<sys/socket.h>,
<netinet/in.h>, <cerrno>, <unistd.h>) which were introduced solely for
the socket-based WoL implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The raw UDP broadcast implementation (port 9, 255.255.255.255) did not reliably wake target hosts. Replace with system("wakeonlan ") which delegates to the wakeonlan tool and works correctly.
If wakeonlan is not installed (exit code 127), a clear error is logged asking the user to install it. The tool is available on Linux distributions and macOS (via Homebrew).
wake_on_lan: also refactors ISNewSwitch() with a handleSend lambda to eliminate code duplication across the 4 device slots, and removes the now-unused socket headers.
lx200_10micron: removes now-unused socket headers (<sys/socket.h>, <netinet/in.h>, , <unistd.h>) which were introduced solely for the socket-based WoL implementation.