Skip to content

feat: Optimistic UI Updates with Automatic Rollback (#440) #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nitishchaubeyy wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: Optimistic UI Updates with Automatic Rollback (#440) #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cdb9c39
fix: enforce onboarding-context guard on referral claims to prevent a…
nitishchaubeyy Jun 11, 2026
7342279
feat: implement route-level lazy loading and update vendor chunking t…
nitishchaubeyy Jun 11, 2026
b2bd22b
feat: implement generic React Error Boundaries to prevent full app un…
nitishchaubeyy Jun 11, 2026
6a7c84e
feat: implement SWR in-memory navigation cache hook to prevent redund…
nitishchaubeyy Jun 11, 2026
e234360
feat: integrate vite-plugin-pwa with workbox for offline caching and …
nitishchaubeyy Jun 11, 2026
5a292f6
feat: complete a11y audit, resolving ARIA and keyboard navigation gap…
nitishchaubeyy Jun 11, 2026
26d453e
feat: implement optimistic UI updates with automatic rollback for fol…
nitishchaubeyy Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion firestore.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ service cloud.firestore {
// Locks referralPoints to the actual totalEarned value in the referrals index.
allow update: if isAuthenticated()
&& request.auth.uid != uid
// 🛡️ NEW GUARD (Issue #432): Only users actively onboarding can trigger a referral point grant
&& get(/databases/$(database)/documents/users/$(request.auth.uid)).data.onboardingStatus == "incomplete"
// Prevent modifying any root-level fields other than points
&& request.resource.data.diff(resource.data).affectedKeys().hasOnly(['points'])
// FIX: Sync referralPoints directly with the referrals index document's totalEarned counter
Expand All @@ -120,7 +122,6 @@ service cloud.firestore {
&& request.resource.data.points.auditorPoints == resource.data.points.auditorPoints
&& exists(/databases/$(database)/documents/referrals/$(uid))
&& request.auth.uid in get(/databases/$(database)/documents/referrals/$(uid)).data.usedBy;
}

match /referrals/{uid} {
allow read: if isAuthenticated();
Expand All @@ -131,6 +132,8 @@ service cloud.firestore {
// Allow either the owner to write, OR a referred user to atomically append their UID
allow update: if isOwner(uid) || (
isAuthenticated()
// 🛡️ NEW GUARD (Issue #432): Prevent existing users from arbitrarily claiming codes
&& get(/databases/$(database)/documents/users/$(request.auth.uid)).data.onboardingStatus == "incomplete"
&& !(request.auth.uid in resource.data.usedBy)
&& request.resource.data.usedBy.size() == resource.data.usedBy.size() + 1
&& request.resource.data.usedBy[resource.data.usedBy.size()] == request.auth.uid
Expand Down
Loading
Loading