Skip to content

[#704] JUnit 6#705

Open
tristantarrant wants to merge 2 commits into
infinispan:mainfrom
tristantarrant:704/junit6
Open

[#704] JUnit 6#705
tristantarrant wants to merge 2 commits into
infinispan:mainfrom
tristantarrant:704/junit6

Conversation

@tristantarrant

Copy link
Copy Markdown
Member

Closes #704

@tristantarrant tristantarrant requested a review from a team as a code owner June 22, 2026 10:46
@tristantarrant tristantarrant changed the title 704/junit6 [#704] JUnit 6 Jun 22, 2026
@github-actions

Copy link
Copy Markdown

⚠️ AI/IDE/CI Configuration Changes

This PR includes changes to AI assistant, IDE, or GitHub Actions/workflow configuration files. These changes can affect how AI assistants interact with this codebase or how CI pipelines run. Please review carefully.

Changed files:

  • AI-CODE.md
  • AI-ISSUES.md
  • AI-TEST.md
  • AI.md

@github-actions github-actions Bot added the ai-config Changes to AI assistant, IDE, or CI configuration label Jun 22, 2026

@jabolina jabolina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take that the AI files belong to another PR?

.attribute("elem1")
.type(AnnotationElement.AttributeType.BOOLEAN)
.defaultValue(null); // exception expected here
var ex = assertThrows(IllegalArgumentException.class, () -> {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ban var!!!


assertTrue("Does not contain:\n" + message, message.contains("Message for 'Person'"));
assertTrue("Does not contain:\n" + message, message.contains("Field number '1' has reserved name '_type'"));
assertTrue(message.contains("Message for 'Person'"));

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some assertions lose the debug message.

@tristantarrant

Copy link
Copy Markdown
Member Author

I take that the AI files belong to another PR?

#701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-config Changes to AI assistant, IDE, or CI configuration pr/needs rebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to JUnit 6

2 participants